Skip to content

hotfix(fetcher): align secrets pattern with reporter chart#1228

Closed
ferr3ira-gabriel wants to merge 1 commit intomainfrom
hotfix/fetcher-secrets-pattern
Closed

hotfix(fetcher): align secrets pattern with reporter chart#1228
ferr3ira-gabriel wants to merge 1 commit intomainfrom
hotfix/fetcher-secrets-pattern

Conversation

@ferr3ira-gabriel
Copy link
Copy Markdown
Member

Summary

This hotfix aligns the fetcher chart secrets pattern with the reporter chart for consistency.

Problem

  • Fetcher chart templates used .Values.manager.secrets and .Values.worker.secrets
  • Reporter chart templates use shared .Values.secrets for both manager and worker
  • This inconsistency caused confusion and issues with ExternalSecrets configuration

Changes

  • templates/manager/secrets.yaml: Changed from .Values.manager.secrets to .Values.secrets
  • templates/worker/secrets.yaml: Changed from .Values.worker.secrets to .Values.secrets
  • values.yaml: Moved all secrets to shared secrets: section
  • values-template.yaml: Same as values.yaml
  • Chart.yaml: Bumped version to 2.1.2

Result

Both fetcher-manager and fetcher-worker secrets now contain the same keys from the shared secrets: section, matching the reporter chart pattern.

Testing

  • helm lint passes
  • helm template generates correct secrets for both manager and worker

- Change manager/worker secrets templates to use shared .Values.secrets
- Move all secrets from manager.secrets and worker.secrets to root secrets section
- Both manager and worker secrets now contain identical keys
- Matches reporter chart pattern for consistency

Bump chart version to 2.1.2

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@ferr3ira-gabriel ferr3ira-gabriel requested a review from a team as a code owner April 16, 2026 19:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 266c4c20-89bc-4f9b-8b9b-094ea65d909d

📥 Commits

Reviewing files that changed from the base of the PR and between 0676ed2 and 1492ea9.

📒 Files selected for processing (5)
  • charts/fetcher/Chart.yaml
  • charts/fetcher/templates/manager/secrets.yaml
  • charts/fetcher/templates/worker/secrets.yaml
  • charts/fetcher/values-template.yaml
  • charts/fetcher/values.yaml

Walkthrough

This PR updates the Helm chart version to 2.1.2 and refactors secret configuration storage. Secrets are consolidated from per-component blocks (manager.secrets, worker.secrets) into a shared common.secrets block, with templates updated to reference the new centralized location.

Changes

Cohort / File(s) Summary
Chart Version
charts/fetcher/Chart.yaml
Updated Helm chart version from 2.1.1 to 2.1.2.
Secret Templates
charts/fetcher/templates/manager/secrets.yaml, charts/fetcher/templates/worker/secrets.yaml
Modified template iteration to reference .Values.secrets instead of component-specific paths (.Values.manager.secrets and .Values.worker.secrets). Base64 encoding and quoting behavior remains unchanged.
Values Configuration
charts/fetcher/values-template.yaml, charts/fetcher/values.yaml
Consolidated secret definitions from per-component blocks into shared common.secrets. Removed manager.secrets and worker.secrets blocks; added APP_ENC_KEY, APP_ENC_KEY_VERSION, file storage and CRM plugin encryption keys, and S3 object storage credentials to common.secrets.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant