hotfix(fetcher): align secrets pattern with reporter chart#1228
Closed
ferr3ira-gabriel wants to merge 1 commit intomainfrom
Closed
hotfix(fetcher): align secrets pattern with reporter chart#1228ferr3ira-gabriel wants to merge 1 commit intomainfrom
ferr3ira-gabriel wants to merge 1 commit intomainfrom
Conversation
- Change manager/worker secrets templates to use shared .Values.secrets - Move all secrets from manager.secrets and worker.secrets to root secrets section - Both manager and worker secrets now contain identical keys - Matches reporter chart pattern for consistency Bump chart version to 2.1.2 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis PR updates the Helm chart version to 2.1.2 and refactors secret configuration storage. Secrets are consolidated from per-component blocks ( Changes
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hotfix aligns the fetcher chart secrets pattern with the reporter chart for consistency.
Problem
.Values.manager.secretsand.Values.worker.secrets.Values.secretsfor both manager and workerChanges
.Values.manager.secretsto.Values.secrets.Values.worker.secretsto.Values.secretssecrets:sectionResult
Both
fetcher-managerandfetcher-workersecrets now contain the same keys from the sharedsecrets:section, matching the reporter chart pattern.Testing
helm lintpasseshelm templategenerates correct secrets for both manager and worker