Skip to content

fix(new): add new configuration options for deployment mode, private upstreams, and reconciliation settings#1238

Merged
guimoreirar merged 1 commit intomainfrom
hotfix/bank-transfer
Apr 17, 2026
Merged

fix(new): add new configuration options for deployment mode, private upstreams, and reconciliation settings#1238
guimoreirar merged 1 commit intomainfrom
hotfix/bank-transfer

Conversation

@guimoreirar
Copy link
Copy Markdown
Member

Midaz Pull Request Checklist

Pull Request Type

  • Midaz
  • Plugin Access Manager
  • Plugin CRM
  • Reporter
  • Plugin Fees
  • Plugin BR PIX Direct JD
  • Plugin BR PIX Indirect BTG
  • Otel Collector
  • Pipeline
  • Documentation
  • Fetcher
  • Matcher
  • Flowker
  • Underwriter

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

…ivate upstreams, and reconciliation settings
@guimoreirar guimoreirar self-assigned this Apr 17, 2026
@guimoreirar guimoreirar requested a review from a team as a code owner April 17, 2026 16:59
@guimoreirar guimoreirar changed the title fix(configmap): add new configuration options for deployment mode, private upstreams, and reconciliation settings fix(new): add new configuration options for deployment mode, private upstreams, and reconciliation settings Apr 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Walkthrough

Updated Helm chart templates for the bank transfer plugin to introduce new environment variables and optional configurations for deployment control, TLS/proxy settings, idempotency, CRM adapter, fees, polling, and reconciliation features, plus MongoDB TLS certificate support.

Changes

Cohort / File(s) Summary
Bank Transfer Plugin ConfigMap
charts/plugin-br-bank-transfer/templates/configmap.yaml
Added environment variables for deployment control (DEPLOYMENT_MODE, ALLOW_PRIVATE_UPSTREAMS), TLS/proxy support (SERVER_PROXY_HEADER, SERVER_TRUSTED_PROXIES), idempotency (DUPLICATE_GUARD_TTL_SEC), CRM adapter configuration (CRM_HOLDER_LOOKUP_PATH_TEMPLATE), fees behavior (FEES_REFUND_ON_DEVOLUCAO), JD polling (JD_POLL_DISABLE_OPERATING_HOURS_WINDOW), and BTF reconciliation settings (BTF_RECONCILIATION_ENABLED, BTF_RECONCILIATION_INTERVAL_SEC, BTF_RECONCILIATION_BATCH_SIZE, BTF_RECONCILIATION_MAX_ATTEMPTS, BTF_RECONCILIATION_STALE_AFTER_SEC). Most variables are conditionally rendered based on provided values.
Bank Transfer Plugin Secrets
charts/plugin-br-bank-transfer/templates/secrets.yaml
Added optional MongoDB TLS CA certificate (MONGO_TLS_CA_CERT) to the Secret template, conditionally included when the corresponding value is provided.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/plugin-br-bank-transfer/templates/configmap.yaml`:
- Around line 10-11: YAMLlint is complaining about "braces: too many spaces
inside braces" for the templated values DEPLOYMENT_MODE and
ALLOW_PRIVATE_UPSTREAMS in configmap.yaml; fix it by removing the extra spaces
immediately inside the Helm template delimiters so the templates read
{{.Values.bankTransfer.configmap.DEPLOYMENT_MODE | default "byoc" | quote}} and
{{.Values.bankTransfer.configmap.ALLOW_PRIVATE_UPSTREAMS | default "false" |
quote}} (i.e., no space after '{{' and before '}}') to satisfy brace-spacing
rules.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d1c86d14-f0e8-408e-bafc-32890123d1e4

📥 Commits

Reviewing files that changed from the base of the PR and between 8c7436b and f1a475e.

📒 Files selected for processing (2)
  • charts/plugin-br-bank-transfer/templates/configmap.yaml
  • charts/plugin-br-bank-transfer/templates/secrets.yaml

Comment thread charts/plugin-br-bank-transfer/templates/configmap.yaml
Copy link
Copy Markdown
Contributor

@gandalf-at-lerian gandalf-at-lerian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean addition — all new entries follow the existing chart patterns (inline defaults with | default, conditional blocks with {{- if .Values... }}).

A few observations:

  1. Reconciliation defaults look reasonable — 30s interval, batch of 20, 5 max attempts, 60s stale threshold. Sane starting points for a bank transfer reconciliation loop.

  2. MONGO_TLS_CA_CERT in secrets — correct placement. Conditional so it won't create noise for non-TLS setups.

  3. DEPLOYMENT_MODE default "byoc" — makes sense as the safe default (bring-your-own-cloud vs managed).

  4. No values.yaml changes — the inline defaults in templates are consistent with the existing chart convention, so this is fine. Worth documenting the new keys in the chart's README or values reference at some point though.

Minor: none of the PR checklist items are checked. Not blocking, but worth ticking off.

LGTM ✅

@guimoreirar guimoreirar merged commit 653577f into main Apr 17, 2026
3 of 4 checks passed
@guimoreirar guimoreirar deleted the hotfix/bank-transfer branch April 17, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants