Add device_name classmethod in Accelerator.#21112
Add device_name classmethod in Accelerator.#21112GdoongMathew wants to merge 38 commits intoLightning-AI:masterfrom
device_name classmethod in Accelerator.#21112Conversation
device_name classmethod in Accelerator.device_name classmethod in Accelerator.
This comment was marked as off-topic.
This comment was marked as off-topic.
justusschock
left a comment
There was a problem hiding this comment.
How would you handle heterogeneous gpu types? E.g. say I have one 3090 and one 4090 in my workstation. This doesn't handle it at all.
Hi @justusschock , based on the change, the output should look something like that being said, if the setup is more complex - for example 2 x 3090 and 1 x 4090 - the current output might not fully reflect that. |
This comment has been minimized.
This comment has been minimized.
|
Hi @Borda , a friendly ping for a review ~ |
unfortunatly, I am not in a position to approve a feature type PR, lest ping @ethanwharris |
# Conflicts: # src/lightning/pytorch/accelerators/xla.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21112 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 270 267 -3
Lines 24071 24055 -16
=========================================
- Hits 20867 18986 -1881
- Misses 3204 5069 +1865 |
# Conflicts: # src/lightning/pytorch/CHANGELOG.md
What does this PR do?
Fixes #17355
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21112.org.readthedocs.build/en/21112/