Conversation
Contributor
There was a problem hiding this comment.
Review found no issues; the UI change correctly enforces immutable production status for prod and aligns behavior with existing environment rules.
Status: No Issues Found | Risk: Low
Review Details
📁 1 files reviewed | 💬 0 comments
Instruction Files
└── .claude/
├── agents/
│ └── nango-docs-migrator.md
└── skills
TBonnin
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prodis a special environment that can't be renamed, deleted, and is alwaysis_production = true. But the latter was not correctly reflected in the UI.After change:
Disable
prodProduction Status Toggle in Environment Settings UIThis PR fixes a UI behavior in
packages/webapp/src/pages/Environment/Settings/General.tsxso the specialprodenvironment can no longer have its production status toggled. The production switch is now explicitly disabled whenenv === PROD_ENVIRONMENT_NAME, aligning frontend behavior with the existing rule thatprodis always production.It also improves UX by wrapping the switch in
ConditionalTooltipto explain why the control is disabled forprod. Existing permission-based gating viaPermissionGateand toggle confirmation flow remain in place for non-prodenvironments.This summary was automatically generated by @propel-code-bot