feat(integrations): add support for cisco duo admin#5820
feat(integrations): add support for cisco duo admin#5820hassan254-prog wants to merge 5 commits intomasterfrom
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7c5227ee0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cadb291d23
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
hassan254-prog
force-pushed
the
wari/add-support-for-cisco-duo
branch
from
cadb291 to
6cff177
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cff17793c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| headers: | ||
| date: '${now:ddd, DD MMM YYYY HH:mm:ss ZZ}' | ||
| authorization: "Basic ${base64(${credentials.username}:${hmacSha1Hex(${now:ddd, DD MMM YYYY HH:mm:ss ZZ}\n${method}\n${connectionConfig.hostname}\n${path}\n${params}, ${credentials.password})})}" |
There was a problem hiding this comment.
Duo signs POST parameters from an application/x-www-form-urlencoded body, but this provider only defines date and authorization headers, so POST/PUT requests with object data are sent as JSON by default while buildCanonicalParams signs them as URL-encoded key/value pairs. That mismatch causes signature validation failures (e.g., 40103) on write endpoints unless every caller manually overrides headers/body format. Add provider-level form encoding (header + serialization path) so signed bytes match transmitted bytes.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The body format form is not needed at the provider level because the proxy passes through the request body as-is; callers are expected to set the correct Content-Type headers and serialize the body themselves.
1 participant
Describe the problem and your solution