Skip to content

fix "NullPointerException throw by maybeReadTimeOut() that can cause Eureka cluster registration inconsistency" #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laniakea1990 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix "NullPointerException throw by maybeReadTimeOut() that can cause Eureka cluster registration inconsistency" #1498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions eureka-core/src/main/java/com/netflix/eureka/cluster/ReplicationTaskProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,20 @@ private static boolean isNetworkConnectException(Throwable e) {
*/
private static boolean maybeReadTimeOut(Throwable e) {
do {
if (IOException.class.isInstance(e)) {
String message = e.getMessage().toLowerCase();
Matcher matcher = READ_TIME_OUT_PATTERN.matcher(message);
if(matcher.find()) {
return true;
}
try {
if (IOException.class.isInstance(e)) {
# !!!this line may occurs NullPointerException in some scenarios.
String message = e.getMessage().toLowerCase();
Matcher matcher = READ_TIME_OUT_PATTERN.matcher(message);
if(matcher.find()) {
return true;
}
}
e = e.getCause();
} catch (Exception ex) {
logger.error("Unexpected other exception occurs when check if the income param e is socket read time out exception ", ex);
return false;
}
e = e.getCause();
} while (e != null);
return false;
}
Expand Down