chore: Remove DRF completely and its broken view#986
Open
Erethon wants to merge 1 commit intoNixOS:mainfrom
Open
chore: Remove DRF completely and its broken view#986Erethon wants to merge 1 commit intoNixOS:mainfrom
Erethon wants to merge 1 commit intoNixOS:mainfrom
Conversation
Collaborator
|
We should probably just fix the bug and write a regression test. The reason this happened is because that code isn't exercised automatically. So some upstream change destroyed it. But if no one gets around to it quickly we should chuck it out, yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this as a reply to #985 (which merging this PR will close #985). If we don't care about DRF and think we should get rid of it for now, this PR completely removes any DRF code, the broken view it's used in and removes it from the dependencies as well.