Skip to content

chore: Remove DRF completely and its broken view#986

Open
Erethon wants to merge 1 commit intoNixOS:mainfrom
Erethon:remove-drf
Open

chore: Remove DRF completely and its broken view#986
Erethon wants to merge 1 commit intoNixOS:mainfrom
Erethon:remove-drf

Conversation

@Erethon
Copy link
Copy Markdown
Collaborator

@Erethon Erethon commented Apr 9, 2026

I'm opening this as a reply to #985 (which merging this PR will close #985). If we don't care about DRF and think we should get rid of it for now, this PR completely removes any DRF code, the broken view it's used in and removes it from the dependencies as well.

@Erethon Erethon marked this pull request as ready for review April 9, 2026 00:20
@fricklerhandwerk
Copy link
Copy Markdown
Collaborator

fricklerhandwerk commented Apr 9, 2026

We should probably just fix the bug and write a regression test.


shared/views.py", line 29, in get_cve
   return [cve.cve_id for cve in obj.cve.iterator()]
                                 ^^^^^^^

Exception Type: AttributeError at /api/v1/issues/
Exception Value: 'NixpkgsIssue' object has no attribute 'cve'

The reason this happened is because that code isn't exercised automatically. So some upstream change destroyed it.

But if no one gets around to it quickly we should chuck it out, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of Django Rest Framework until we actually start using it?

2 participants