Conversation
…tion test
README.md
- Rename 'Quick start' to 'Setup and quick start'; add install steps for
TypeScript (ts/sdk needs separate npm install from ts/), Docker Compose
entry, and explanation of MTA_SIG_ALG / MTA_ORIGIN env vars
- Add 'Payload modes' section before the interop tables explaining Mode 0
(not yet implemented), Mode 1 (default, proof embedded), and Mode 2
(online, no proof embedded, SDK does not fetch tiles) — with the critical
Mode 2 limitation called out clearly
- Retitle 'Payload modes' API section to 'Payload mode API' to avoid
duplicating the explanation
MlDsaVerifyTest.java
- Restore the cross-language end-to-end verification test that was deleted
when it referenced /home/claude/interop-test/ (an absolute path only
present on the development machine)
- Rewritten as issueAndVerifyEndToEnd(): uses the Java issuer to generate
a Mode 1 ML-DSA-44 payload and trust config inline, then verifies with
the Java verifier — covers the same code paths (checkpoint body construction,
ML-DSA-44 note signing, cosignature quorum, inclusion proof, TBS decode)
without any external file dependencies
- Java test count restored from 9 back to 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md: Adds proper Setup section with install steps, explains all three payload modes before the interop tables (Mode 0 unimplemented, Mode 1 default, Mode 2 limitation), renames the API section to avoid duplication.
MlDsaVerifyTest.java: Restores the end-to-end verification test that was deleted because it read from
/home/claude/interop-test/. Rewritten to generate all fixtures inline using the Java issuer — tests the same ML-DSA-44 code paths without external file dependencies. Java test count: 9 → 10.