Open
Conversation
Partially resolves Issue #75 TODO: Also save language setting after it was added to the Launcher Dialog
Warning: currently incomplete (TODO: fix)
pehala
requested changes
Nov 24, 2020
| return true;//instance.serverBox.isSelected(); | ||
| } | ||
|
|
||
| public void loadPreferences() { |
Collaborator
There was a problem hiding this comment.
I would move all this Preferences logic into a separate class and add getters/setters for individual properties, this way we can handle all the logic for one property being unknown there. It will be also easier to test, since we could be mocking individual methods in that new class instead of the entire properties.
Collaborator
There was a problem hiding this comment.
Getters could return Optional and the individual getters could work like this:
- Is the property in loaded properties?
- Yes, return the property
- Not, return empty Optional
Owner
Author
|
Sorry but I have to delay further work to a later point in time. I am currently not able to invest time in the project. Sorry for that! |
Collaborator
|
Its fine, I am currently in the same situation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests do not work at the moment.
TODOs: