Properly decode download requests as UTF-8.#982
Open
gibbed wants to merge 1 commit intoPoE-TradeMacro:masterfrom
Open
Properly decode download requests as UTF-8.#982gibbed wants to merge 1 commit intoPoE-TradeMacro:masterfrom
gibbed wants to merge 1 commit intoPoE-TradeMacro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the return value of
PoEScripts_Downloadso that it properly decodes UTF-8 data, allowing TradeMacro to properly handle Korean character names.Currently search results have heavy use of
StrPadfor formatting, which this change butts right up against and will require further rework of tooltip rendering for these before this fix should be merged.As far as I can tell, all calls to
PoEScripts_Downloaddon't specify or otherwise ask for an encoding ofUTF-8.I left the default encoding as
CP850to retain the previous behavior for unmodified calls toStdOutStream.