Conversation
lkstrp
reviewed
Apr 30, 2026
Member
lkstrp
left a comment
lkstrp
left a comment
There was a problem hiding this comment.
Thanks @KristijanFaust-OET !
My main concern is making it a bit more strict on which env vars can be passed. See comment. Otherwise could you add/ update the tests? They don't run in the CI yet, but we have some
|
|
||
| from pydantic import BaseModel, Field, field_validator | ||
|
|
||
| _VALID_ENV_VAR_NAME = re.compile(r"^[A-Za-z_][A-Za-z0-9_]*$") |
Member
There was a problem hiding this comment.
Isn't that a bit too wide? I wouldn't say this project is currently hardened at all, but not sure if we should open up overwriting all env vars. What do you think about even whitelisting specific env vars in the config? That would already be sufficient for OETC
Collaborator
Author
There was a problem hiding this comment.
Totally agree. I went with the simplest implementation but whitelisting makes much more sense. Refactored in: dfd8f59
lkstrp
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.