Fix display On state handling for purifier accessories#124
Open
ITDevTom wants to merge 1 commit intoRaresAil:masterfrom
Open
Fix display On state handling for purifier accessories#124ITDevTom wants to merge 1 commit intoRaresAil:masterfrom
ITDevTom wants to merge 1 commit intoRaresAil:masterfrom
Conversation
Preserve explicit false values when refreshing VeSync fan state so Homebridge characteristics do not receive undefined for boolean-backed properties. This fixes the DeviceDisplay accessory path where the Lightbulb On characteristic could emit warnings such as 'characteristic value expected boolean and received undefined' when the purifier display was off. Also stop the experimental display setter from updating CurrentAirPurifierState with a boolean payload. That setter belongs to the display light service and should only change the display state; writing a boolean into CurrentAirPurifierState is the wrong characteristic contract. Add an explicit tsconfig types list for node and homebridge so the plugin builds cleanly against the linked local Homebridge checkout without inheriting unrelated ambient browser or React types from the surrounding workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve explicit false values when refreshing VeSync fan state so Homebridge characteristics do not receive undefined for boolean-backed properties. This fixes the DeviceDisplay accessory path where the Lightbulb On characteristic could emit warnings such as 'characteristic value expected boolean and received undefined' when the purifier display was off.
Also stop the experimental display setter from updating CurrentAirPurifierState with a boolean payload. That setter belongs to the display light service and should only change the display state; writing a boolean into CurrentAirPurifierState is the wrong characteristic contract.
Add an explicit tsconfig types list for node and homebridge so the plugin builds cleanly against the linked local Homebridge checkout without inheriting unrelated ambient browser or React types from the surrounding workspace.