Dump stacktraces from goroutines on timeouts for inspection#442
Open
driv3r wants to merge 4 commits into
Open
Conversation
austenLacy
approved these changes
Jun 16, 2026
Add bounded Ruby test synchronization and watchdog diagnostics so CI hangs fail with useful output instead of reaching the job timeout. - Replace unbounded status-handler sleeps with a BlockingGate helper - Track active Ghostferry status handlers for timeout diagnostics - Add bounded subprocess joins with Ruby thread and Go goroutine dumps - Add per-test Ruby wall-clock watchdog - Keep expected interrupt/failure panic stacks buffered instead of live-printing - Configure Go test timeouts and GOTRACEBACK for fuller goroutine dumps
Replace the ConditionVariable-based per-test watchdog with a Queue-backed interruptible timer so normal teardown cancels the watchdog reliably. The previous implementation could wake during teardown and incorrectly fire while the main test thread was joining the watchdog, causing a false timeout diagnostic and aborting otherwise healthy tests. - Use Thread::Queue#pop(timeout:) to distinguish release vs timeout - Capture watchdog state in locals to avoid cross-test ivar aliasing - Keep timeout diagnostics unchanged for genuine stuck tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help debug timeouts that we are having in tests