WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) by jtp10181 · Pull Request #2681 · SmartThingsCommunity/SmartThingsEdgeDrivers

jtp10181 · 2026-01-02T04:17:13Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding Zooz ZSE50 for WWST Certification

Summary of Completed Tests

Tested all features manually
Passed full integration test from the developer test suite

drivers/SmartThings/zwave-siren/profiles/zooz-zse50.yml

drivers/SmartThings/zwave-siren/src/init.lua

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

greens · 2026-01-14T00:05:08Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  tones_list[tone_id] = string.format("%s: %s (%ss)", tone_id, tone_name, duration)
+  tones_duration[tone_id] = duration
+  device:set_field("TONES_LIST_TMP", tones_list)
+  device:set_field("TONES_DURATION_TMP", tones_duration)


it seems a little redundant to use two maps here where the only unique information one of them includes is the tone_name. Could you just use one map like:

{ [tone_id] = {duration: X, name: Y} }

And construct the strings in the places you actually want to emit them?

Also, the value of capabilities.mode.supportedArguments will be identical to device:get_field("TONES_LIST") most of the time, so it seems especially redundant there.

Implemented your suggestion in 243ec27

greens

Please write and include some unit tests and remove your debug logging.

jtp10181 · 2026-01-14T16:33:19Z

I will work on the remaining issues and follow up when complete.

* Remove firmwareUpdate from driver_template * Fix copyright date * Remove unnecessary profile switch

pegor-karoglanian · 2026-02-05T16:58:55Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+      duration = duration * device.preferences.playbackLoop
+    end
+  end
+  log.debug(string.format("Playing Tone: %s, playbackMode %s, duration %ss", tone_id, playbackMode, duration))


Please remove debug log once you are ok with functionality.

Is it OK to keep some as Info logs? I removed a bunch but changed this one to Info.

pegor-karoglanian · 2026-02-05T16:59:12Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  local soundSwitch_refresh = function()
+    local chime = device:get_latest_state("main", capabilities.chime.ID, capabilities.chime.chime.NAME)
+    local mode = device:get_latest_state("main", capabilities.mode.ID, capabilities.mode.mode.NAME)
+    log.debug(string.format("soundSwitch_refresh: %s | %s", chime, mode))


Same as above

I changed this one to Info log as well if thats OK.

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

wkhenon · 2026-02-12T19:29:05Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

Reiterating some of the comments that Pegor left, be sure to remove all usages of log.debug() from this file was your implementation is complete.

cbaumler · 2026-03-20T19:24:29Z

Hi @jtp10181 let us know when you're ready for a re-review.

jtp10181 · 2026-03-21T02:30:35Z

Hi @jtp10181 let us know when you're ready for a re-review.

Will do, I got caught up on a bunch of other stuff finally, so hope to circle back to this one soon.

github-actions · 2026-04-05T01:18:21Z

Duplicate profile check: Passed - no duplicate profiles detected.

…ren_zse50

github-actions · 2026-04-05T01:19:13Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/gV2qxBdXOeM9

github-actions · 2026-04-05T01:20:27Z

Test Results

72 files 496 suites 0s ⏱️
2 738 tests 2 738 ✅ 0 💤 0 ❌
4 614 runs 4 614 ✅ 0 💤 0 ❌

Results for commit b7a24a7.

♻️ This comment has been updated with latest results.

github-actions · 2026-04-05T01:20:28Z

File	Coverage
All files	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/multifunctional-siren/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/apiv6_bugfix/can_handle.lua	`66%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/aeotec-doorbell-siren/init.lua	`85%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/philio-sound-siren/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zwave-sound-sensor/init.lua	`84%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/preferences.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/configurations.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/utilitech-siren/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/yale-siren/init.lua	`88%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zipato-siren/init.lua	`92%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b7a24a7

* Merged upstream and updated for lazy-load * Consolidated tones_list and tones_duration maps as suggested * Removed debug logs and commented out code

* Added units tests

Removed audioVolume from supported capabilities so main unit test does not fail.

Added more units tests to increase coverage

jtp10181 · 2026-04-05T21:48:31Z

Hi @jtp10181 let us know when you're ready for a re-review.

Will do, I got caught up on a bunch of other stuff finally, so hope to circle back to this one soon.

Ok @greens, @wkhenon, @cbaumler
I think I have this all squared away now. I believe I addressed all issues and added 24 unit tests to get it to 95%. I think the two failing checks are some sort of issue with the bot itself and not an issue with the code.

I really hate making unit tests so I decided to have Copilot help make then, worked great once I told it to ingest all the other ones in the same folder for examples.

cjswedes · 2026-04-07T22:29:23Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  if tones_list == nil or tones_list == {} then
+    rebuildTones(device)
+  end


If this statement is true, the tones list could be nil, and then there would be a nil index error on line 200.

Suggested change

if tones_list == nil or tones_list == {} then

rebuildTones(device)

end

if tones_list == nil or tones_list == {} then

rebuildTones(device)

return

end

I did not want to bail on playing the tone here so I fixed the now line 201 to be nil safe so it will fail over to my default as intended.

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

Line 201 in b7a24a7

local toneInfo = (tones_list or {})[tone_id] or { name = "Unknown", duration = "0" }

cjswedes · 2026-04-07T22:30:43Z

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

+  local tones_list = device:get_field("TONES_LIST")
+  local default_tone = device:get_field("TONE_DEFAULT")


These need to be nil checked to make sure we avoid nil index errors on lines 52 and 54.

I added a nil fall back to 47

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

Line 47 in b7a24a7

local default_tone = device:get_field("TONE_DEFAULT") or 1

Then for the other one I rearranged some things below and added a nil check for tones_list to the only if block using it. The duration is now set to 0 by default when initialized as well.

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua

Line 55 in b7a24a7

elseif tones_list ~= nil and tone_id > 0 then

jtp10181 added 2 commits January 1, 2026 22:03

Add Zooz ZSE50 to zwave-siren

2f5426e

Fix fingerprint deviceLabel for ZSE50

3b569c8

greens requested review from pegor-karoglanian and wkhenon January 13, 2026 23:32

greens reviewed Jan 13, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/profiles/zooz-zse50.yml Show resolved Hide resolved

greens reviewed Jan 13, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/init.lua Outdated Show resolved Hide resolved

greens reviewed Jan 13, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated Show resolved Hide resolved

greens reviewed Jan 13, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Show resolved Hide resolved

greens reviewed Jan 13, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated Show resolved Hide resolved

greens reviewed Jan 13, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Show resolved Hide resolved

greens reviewed Jan 14, 2026

View reviewed changes

greens changed the title ~~Add Zooz ZSE50 to zwave-siren (for WWST Cert)~~ WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) Jan 14, 2026

zwave-siren WWST fixes

310a022

* Remove firmwareUpdate from driver_template * Fix copyright date * Remove unnecessary profile switch

pegor-karoglanian reviewed Feb 5, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated Show resolved Hide resolved

pegor-karoglanian reviewed Feb 5, 2026

View reviewed changes

drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated Show resolved Hide resolved

wkhenon reviewed Feb 12, 2026

View reviewed changes

KKlimczukS requested a review from cbaumler March 19, 2026 13:04

Merge branch 'main' into zwave-siren_zse50

90dbff1

Merge remote-tracking branch 'origin/zwave-siren_zse50' into zwave-si…

d602722

…ren_zse50

zwave-siren ZSE50 more fixes

243ec27

* Merged upstream and updated for lazy-load * Consolidated tones_list and tones_duration maps as suggested * Removed debug logs and commented out code

jtp10181 added 3 commits April 5, 2026 15:33

zwave-siren ZSE50 unit tests

1741417

* Added units tests

zwave-siren ZSE50 unit tests fixes

166b6b0

Removed audioVolume from supported capabilities so main unit test does not fail.

zwave-siren ZSE50 unit tests fixes

ad0bc7c

Added more units tests to increase coverage

cbaumler requested review from aleclorimer and cjswedes April 6, 2026 15:38

aleclorimer approved these changes Apr 7, 2026

View reviewed changes

cjswedes reviewed Apr 7, 2026

View reviewed changes

zwave-siren ZSE50 nil checks

b7a24a7

		local tones_list = device:get_field("TONES_LIST")
		local default_tone = device:get_field("TONE_DEFAULT")

Conversation

jtp10181 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

jtp10181 commented Jan 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cbaumler commented Mar 20, 2026

Uh oh!

jtp10181 commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtp10181 commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtp10181 Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtp10181 Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jtp10181 commented Jan 2, 2026 •

edited

Loading

jtp10181 commented Mar 21, 2026 •

edited

Loading

github-actions bot commented Apr 5, 2026 •

edited

Loading

github-actions bot commented Apr 5, 2026 •

edited

Loading

jtp10181 commented Apr 5, 2026 •

edited

Loading

jtp10181 Apr 8, 2026 •

edited

Loading

jtp10181 Apr 8, 2026 •

edited

Loading