Aqara Wireless Knob Switch H1#2844
Merged
cbaumler merged 5 commits intoSmartThingsCommunity:mainfrom Apr 7, 2026
Merged
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 72 files 495 suites 0s ⏱️ Results for commit a56dcd1. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a56dcd1 |
aleclorimer
reviewed
Mar 27, 2026
| @@ -0,0 +1,149 @@ | |||
| -- Copyright 2024 SmartThings | |||
Contributor
Author
There was a problem hiding this comment.
Fixed the copyright year. Thanks for the review!
cjswedes
reviewed
Mar 30, 2026
Contributor
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
Looks pretty good. Just a few small optimizations and a couple extra tests requested to be added.
drivers/SmartThings/zigbee-button/profiles/aqara-knob-switch.yml
Outdated
Show resolved
Hide resolved
cjswedes
approved these changes
Apr 3, 2026
|
|
||
| local function do_configure(driver, device) | ||
| device:configure() | ||
| device:send(cluster_base.write_manufacturer_specific_attribute(device, |
Contributor
There was a problem hiding this comment.
nit: a comment here about what this attribute write is doing would be nice to understand why it is needed.
| local sensitivity = tonumber(device.preferences[SENSITIVITY_KEY]) | ||
| local factor = SENSITIVITY_FACTORS[sensitivity] or 1.0 | ||
| local intermediate_val = raw_val * factor | ||
| local sign = (intermediate_val > 0 and 1) or (intermediate_val < 0 and -1) or 0 |
Contributor
|
Also, just a reminder to ensure the luacheck passes (removing whitespace, unused variables, etc) before merging. Thanks! |
hcarter-775
reviewed
Apr 6, 2026
Comment on lines
+55
to
+56
| device:emit_event(capabilities.knob.rotateAmount({value = 0, unit = "%"})) | ||
| device:emit_event(capabilities.knob.heldRotateAmount({value = 0, unit = "%"})) |
Contributor
There was a problem hiding this comment.
Suggested change
| device:emit_event(capabilities.knob.rotateAmount({value = 0, unit = "%"})) | |
| device:emit_event(capabilities.knob.heldRotateAmount({value = 0, unit = "%"})) | |
| device:emit_event(capabilities.knob.rotateAmount(0)) | |
| device:emit_event(capabilities.knob.heldRotateAmount(0)) |
nit: The rotate attributes do not support a unit in their arguments. The command passes through fine but the unit does not actually pass into anything. This can be extended to all uses of these attributes.
hcarter-775
approved these changes
Apr 6, 2026
Contributor
Author
|
Thank you @cjswedes and @hcarter-775 for the detailed review! I have updated the code to:
The tests have also been updated to reflect these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests