Fixed issue where assigning customer group to a category caused an error when trying to duplicate menu#371
Open
Riyaprajapat wants to merge 1 commit intoSnowdogApps:developfrom
Open
Conversation
…rror when trying to duplicate menu
adamwaclawczyk
requested changes
Jul 17, 2025
|
|
||
| $nodeClone->setData($node->getData()); | ||
| if (isset($data['customer_groups'])) { | ||
| $data['customer_groups'] = json_encode((array)$data['customer_groups']); |
Contributor
There was a problem hiding this comment.
In code where customerGroups is serialized, unserialized we are using Magento\Framework\Serialize\SerializerInterface
Let's keep this uniform across this module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description:
When customer groups are assigned to a category in a Menu, attempting to duplicate that menu results an error. As a result, the menu cannot be duplicated successfully.
Screenshot-1:

Screenshot-2:

Screenshot-3:

Steps to Reproduce:
Expected Results:
The menu should duplicate successfully, even if customer groups are assigned to categories.
Actual Results:
An error occurs during the duplication process, and the menu cannot be duplicated.
Additional Information:
File path: snowdog/module-menu/Service/Menu/Cloner.php
When cloning the menu, the code at line 119 uses $nodeClone->setData($node->getData()); to copy all data. However, in the original menu, the customer_groups field is saved as a JSON string like ["0", "1", "2", "3"], but after cloning, it becomes a plain array or comma-separated values like 0,1,2,3. This difference in format causes the error “Unable to unserialize value. Error: Syntax error” when saving the cloned menu. To fix this, the customer_groups value should be converted back to a JSON string before saving the cloned node.