Fix GraphQL node loading for duplicate identifiers and add cms block content#396
Open
sashagfu wants to merge 1 commit intoSnowdogApps:developfrom
Open
Fix GraphQL node loading for duplicate identifiers and add cms block content#396sashagfu wants to merge 1 commit intoSnowdogApps:developfrom
sashagfu wants to merge 1 commit intoSnowdogApps:developfrom
Conversation
|
Related Issue #397 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves GraphQL support for menu nodes in two areas:
Why
In multi-store Magento setups, different menus may use the same identifier across stores. The GraphQL resolver correctly resolves the menu in the current store context first,
but then loads nodes again by identifier. This may return nodes from other menus that share the same identifier.
Also, cms_block nodes currently do not return rendered block content in GraphQL.
Changes
Validation
Validated manually in a real Magento project: