fix: guard against empty choices before accessing response.choices[0]#1552
Open
qizwiz wants to merge 1 commit into
Open
fix: guard against empty choices before accessing response.choices[0]#1552qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
response.choices is an empty list — not an exception — when the provider applies content filtering or max_tokens is exceeded before any content is generated. Accessing choices[0] without a length check raises IndexError. Adds a guard before the choices access in the chat completion path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a guard before the
response.choices[0]access insuperagi/llms/openai.py.Why
response.choicesis an empty list — not an exception — when the provider applies content filtering ormax_tokensis exceeded before any content is generated. Accessingchoices[0]without a length check raisesIndexErrorin production.Pre-existing test note
tests/unit_tests/llms/test_open_ai.pyfails to import on the base branch due toopenai.InvalidRequestErrorbeing removed in openai v1 (renamed toBadRequestError). This is unrelated to this change.🤖 Generated with Claude Code