PyVista Jupyter notebook visualizer#852
Open
Victorwithak wants to merge 15 commits intoXiangyu-Hu:masterfrom
Open
PyVista Jupyter notebook visualizer#852Victorwithak wants to merge 15 commits intoXiangyu-Hu:masterfrom
Victorwithak wants to merge 15 commits intoXiangyu-Hu:masterfrom
Conversation
Owner
|
@Victorwithak It seems that your python case is not in the test set. Your need a CMakeLists.txt file added so that this will be tested before merging. You can check how other python based test cases. Such as https://github.com/Xiangyu-Hu/SPHinXsys/tree/master/tests/test_python_interface/test_2d_dambreak_python , Also, your case better to be in test_python_interface folder together with opther python based tests. |
Xiangyu-Hu
reviewed
Jul 9, 2025
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# %pip install pyvista vtk" |
Owner
There was a problem hiding this comment.
I think that we need really install the libraries here.
…alizer/Jupyter_Visualizer/test.txt
…alizer/pybind_tool/test.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've finalised the visualizer. I have added the two options of .gif (cross section and full) and some .vtp files to test the jupyter notebook on. I hope I placed it in the correct directory.
I will probably update it this week, since I want to add flow charts to it, but that will come next week.