Skip to content

feat: migrate timestamp extension to a2a 1.0#525

Open
ishymko wants to merge 3 commits intomainfrom
extensions-alpha-2
Open

feat: migrate timestamp extension to a2a 1.0#525
ishymko wants to merge 3 commits intomainfrom
extensions-alpha-2

Conversation

@ishymko
Copy link
Copy Markdown
Member

@ishymko ishymko commented Apr 17, 2026

  1. Migrate to a2a 1.0 alpha 2.
  2. Replace referencing this package from other samples with a folder-local test. Note: required fixing ruff for those files as they were added to diff and ruff got executed, seems like they were not clean before and had many ruff violations.

Replace referencing this package from other samples with a folder-local test.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the timestamp extension to version 1.0.0a2 of the a2a-sdk. Key changes include refactoring the extension to use raw Protobuf types instead of Pydantic models, updating the client interceptor to utilize the new before/after hooks, and adding a comprehensive end-to-end showcase test. The extension was also removed from several sample agents and hosts. Feedback focuses on two high-severity issues where the Python Protobuf API is misused: specifically, the attempt to use .append() on a repeated field and the incorrect initialization of nested message fields in constructors.

Comment thread samples/python/extensions/timestamp/src/timestamp_ext/__init__.py
Comment thread samples/python/extensions/timestamp/tests/test_timestamp_ext.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant