Open
Conversation
Replace referencing this package from other samples with a folder-local test.
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the timestamp extension to version 1.0.0a2 of the a2a-sdk. Key changes include refactoring the extension to use raw Protobuf types instead of Pydantic models, updating the client interceptor to utilize the new before/after hooks, and adding a comprehensive end-to-end showcase test. The extension was also removed from several sample agents and hosts. Feedback focuses on two high-severity issues where the Python Protobuf API is misused: specifically, the attempt to use .append() on a repeated field and the incorrect initialization of nested message fields in constructors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.