Allow renew time relative to the expiration date#4457
Allow renew time relative to the expiration date#4457neilpang merged 5 commits intoacmesh-official:devfrom
Conversation
|
I do not think, the error of the pipeline is related to the pull request. |
5dda252 to
b84acb6
Compare
b84acb6 to
4d9d59a
Compare
|
Any update on this PR? |
|
??? Nothing? |
|
Unfortunately, there has been no response to the pull request yet. We've been using this change in production for a long time, and it works very well. Given the different expiration times for server certificates at different CAs, this is very helpful, and the expiration times will continue to change in the future, so this change is very important for automation. |
|
Looks like someone else needs to take over this project, acmesh-official is not doing anything for pull requests. |
|
Ultimately #4944 ARI support is going to fulfill this need in most cases, I can see that the work has already began. The change in this PR would still be useful nonetheless of course. |
saudiqbal
left a comment
There was a problem hiding this comment.
Please approve the PR for relative expiry date.
|
PR still not accepted! |
|
@neilpang Any comments on this? Did you maybe miss this PR by accident? |
4d9d59a to
3e601f5
Compare
|
please also add thie usage in the showhelp() method, so that everyone knows it can be negative numbers. |
There was a problem hiding this comment.
Pull request overview
Adds support for configuring certificate renewal scheduling relative to the certificate’s expiration date (by allowing negative Le_RenewalDays), addressing scenarios with long-lived certificates (e.g., 1-year ACME certs) as described in #3413.
Changes:
- Introduces
_enddate()to readnotAfterfrom an issued certificate via OpenSSL. - Introduces
_ssldate2time()to convert OpenSSL-enddateoutput into epoch seconds. - Updates next-renew-time calculation to support negative
Le_RenewalDaysas “expire time + (negative days)”.
3e601f5 to
e081347
Compare
|
I have updated the PR and included the various suggestions from Copilot (although the extensive error checking does not align with other parts of the code). |
You can now set a negative value for days, that will be subtracted from the expiration date of the generated certificate.
_enddate is also a function and it is better to use different names for functions and variables for better maintainability.
e081347 to
4c79890
Compare
* Allow renew time relative to the expiration date
You can now set a negative value for days, that will be subtracted from the expiration date of the generated certificate.
This will fix #3413.