Skip to content

Support list IPv6 address certificate#6696

Merged
neilpang merged 1 commit intoacmesh-official:devfrom
taoso:dev
Dec 23, 2025
Merged

Support list IPv6 address certificate#6696
neilpang merged 1 commit intoacmesh-official:devfrom
taoso:dev

Conversation

@taoso
Copy link
Copy Markdown
Contributor

@taoso taoso commented Dec 19, 2025

acme.sh currently only list ipv4 address 😢

@neilpang neilpang merged commit dba4be8 into acmesh-official:dev Dec 23, 2025
33 of 37 checks passed
@taoso taoso deleted the dev branch December 24, 2025 00:52
@jetsung
Copy link
Copy Markdown

jetsung commented Jan 1, 2026

Changing the loop in the list() function to:

for di in "${CERT_HOME}"/{*.*,*:*}/; do

introduces a serious bug:

  • When there are no directories containing : (the common case), Bash brace expansion does not expand the glob and treats the entire pattern literally.
  • As a result, $di becomes the literal string /path/to/acme.sh/{*.*,*:*}/.
  • Then DOMAIN_CONF is constructed as /acme.sh/{*.*,*:*}//{*.*,*:*}.conf, which obviously does not exist.
  • Outcome: acme.sh --list shows an empty list — no certificates are displayed, including ECC ones.
+ ACME_OPENSSL_BIN=openssl
+ '[' -z  ]
+ return 0
+ _sep='|'
+ '[' raw ]
+ '[' -z  ]
+ printf '%s\n' 'Main_Domain|KeyLength|SAN_Domains|Profile|CA|Created|Renew'
Main_Domain     KeyLength       SAN_Domains     Profile CA      Created Renew
+ basename '/acme.sh/{*.*,*:*}/'
+ d='{*.*,*:*}'
+ _debug d '{*.*,*:*}'
+ '[' 2 -ge 1 ]
+ _log d '{*.*,*:*}'
+ '[' -z /acme.sh/acme.sh.log ]
+ _printargs d '{*.*,*:*}'
+ _exitstatus=1
+ '[' -z  ]
+ date
+ printf -- '%s' '[Thu Jan  1 19:00:49 CST 2026] '
+ '[' -z '{*.*,*:*}' ]
+ printf -- '%s' 'd='"'"'{*.*,*:*}'"'"
+ printf '\n'
+ return 1
+ '[' 0 -ge 7 ]
+ '[' 0 -ge 1 ]
+ _endswith '{*.*,*:*}' _ecc
+ _str='{*.*,*:*}'
+ _sub=_ecc
+ echo '{*.*,*:*}'
+ grep -- '_ecc$'
+ DOMAIN_CONF='/acme.sh/{*.*,*:*}//{*.*,*:*}.conf'
+ '[' -f '/acme.sh/{*.*,*:*}//{*.*,*:*}.conf' ]
+ _ret=0
+ '[' 0 '!=' 0 ]
+ '[' list '=' install ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants