Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates acme.sh and the README in a small “sync” pass: it bumps the script version, improves ARI (RFC 9773) behavior (including an opt-out), and adds/updates relevant wiki links in the documentation.
Changes:
- Bump
acme.shversion to3.1.4. - Add
NO_ARI=1opt-out behavior to skip ARIreplacesand suggestedWindow logic. - Adjust ARI certID computation to handle DER serial sign-byte requirements; refresh README links (DNS persist mode + ARI wiki).
Critical Issues (Must Fix Before Merge)
- Non-portable
grep -Ausage in_getAKI()(impacts cross-platform support).
Suggestions (Improvements to Consider)
- Document
NO_ARI=1in the README ARI section so users can discover the opt-out. - Quote
ACME_OPENSSL_BINwhen invoking OpenSSL to avoid word-splitting/metacharacter issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Adds wiki links for DNS persist mode and ARI, and links “DNS persist mode” in the supported modes table. |
| acme.sh | Version bump; introduces NO_ARI opt-out in ARI paths; fixes ARI serial handling; switches AKI/serial helpers to use ACME_OPENSSL_BIN. |
Comment on lines
505
to
510
| #### 📡 ACME Renewal Information (ARI) — RFC 9773 | ||
|
|
||
| 📖 Wiki: https://github.com/acmesh-official/acme.sh/wiki/ARI | ||
|
|
||
| If the CA exposes a `renewalInfo` endpoint in its ACME directory (Let's Encrypt, ZeroSSL, etc.), `acme.sh` follows [RFC 9773](https://www.rfc-editor.org/rfc/rfc9773.html) automatically — **no flag needed, no opt-in**: | ||
|
|
| _getAKI() { | ||
| _cert="$1" | ||
| openssl x509 -in "$_cert" -text -noout | grep "X509v3 Authority Key Identifier" -A 1 | _tail_n 1 | tr -d ' :' | ||
| ${ACME_OPENSSL_BIN:-openssl} x509 -in "$_cert" -text -noout | grep "X509v3 Authority Key Identifier" -A 1 | _tail_n 1 | tr -d ': ' | sed "s/keyid//" |
Comment on lines
6866
to
6875
| _getAKI() { | ||
| _cert="$1" | ||
| openssl x509 -in "$_cert" -text -noout | grep "X509v3 Authority Key Identifier" -A 1 | _tail_n 1 | tr -d ' :' | ||
| ${ACME_OPENSSL_BIN:-openssl} x509 -in "$_cert" -text -noout | grep "X509v3 Authority Key Identifier" -A 1 | _tail_n 1 | tr -d ': ' | sed "s/keyid//" | ||
| } | ||
|
|
||
| #cert | ||
| _getSerial() { | ||
| _cert="$1" | ||
| openssl x509 -in "$_cert" -serial -noout | cut -d = -f 2 | ||
| ${ACME_OPENSSL_BIN:-openssl} x509 -in "$_cert" -serial -noout | cut -d = -f 2 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync