Add Essential OID4VCI Client Scope Configuration Fields to Admin UI#190
Add Essential OID4VCI Client Scope Configuration Fields to Admin UI#190forkimenjeckayang wants to merge 2 commits intomainfrom
Conversation
Awambeng
left a comment
There was a problem hiding this comment.
Hi @forkimenjeckayang,
Thank you for the PR! 🙌 I have a few minor points I’d like you to clarify.
I noticed that some attributes haven’t been included in the UI, which makes sense based on your explanation. However, I was wondering if a few of them might still be useful to include. For example:
-
vc.credential_build_config.token_jws_type– This is used to set the typ parameter in the JWT (e.g., in our case, we use dc+sd-jwt). -
vc.credential_build_config.sd_jwt.visible_claims– This defines which claims are disclosed in the SD-JWT body. If we ever want to include other claims beyond the defaults, wouldn’t it make sense to integrate this into the UI? -
vc.signing_key_id– This specifies the key used to sign the credential. Would it be possible (and practical) to have a dropdown listing all registered keys in the realm, allowing users to choose which one to use? I’m not sure how complex this might be, but it could be a nice addition.
Awambeng
left a comment
There was a problem hiding this comment.
I have a few comments. Could you please check?
|
@Awambeng |
ba4a676 to
49cea92
Compare
Awambeng
left a comment
There was a problem hiding this comment.
@forkimenjeckayang I’ve added a few comments. Please take a look when you have a moment.
|
Suggestions applied @Awambeng |
IngridPuppet
left a comment
There was a problem hiding this comment.
I checked carefully and it looks very good to me. I left a few minor comments though. Could you please check?
IngridPuppet
left a comment
There was a problem hiding this comment.
Thank you for the update.
Closes: keycloak#43902 Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
ffae373 to
0d57937
Compare
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
This PR adds essential configuration fields for OID4VCI (OpenID for Verifiable Credentials Issuance) client scopes in the Admin UI.
Added Fields
Credential Display (
vc.display)Supported Credential Types (
vc.supported_credential_types)jwt_vcordc+sd-jwtVerifiable Credential Type (
vc.verifiable_credential_type)dc+sd-jwtFormat Dropdown Update
ldp_vc(LDP VC) option from the format dropdown as it is not currently implementeddc+sd-jwt(SD-JWT VC) andjwt_vc(JWT VC) formats are now availableWhy Not Include Other Fields?
Several other OID4VCI attributes were not added to the UI because they:
Examples of excluded fields (with defaults):
vc.proof_signing_alg_values_supported- Defaults to realm's available signing algorithmsvc.cryptographic_binding_methods_supported- Defaults to "jwk"vc.signing_key_id- Optional, defaults to realm's active signing keyvc.sd_jwt.number_of_decoys- Defaults to 10vc.credential_build_config.*- Various SD-JWT build configurations with sensible defaultsThis approach keeps the UI simple and focused on essential configuration while maintaining flexibility for advanced users via the REST API.
Closses