Skip to content

chore: upgrade playwright#1668

Open
daniel-graham-amplitude wants to merge 1 commit intomainfrom
no-ticket-upgrade-playwright
Open

chore: upgrade playwright#1668
daniel-graham-amplitude wants to merge 1 commit intomainfrom
no-ticket-upgrade-playwright

Conversation

@daniel-graham-amplitude
Copy link
Copy Markdown
Collaborator

@daniel-graham-amplitude daniel-graham-amplitude commented Apr 9, 2026

Summary

Tests are failing to get Playwright container.

Try upgrading to the latest container, perhaps the old one is unpublished.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Note

Low Risk
Low risk: workflow-only change updating the Playwright Docker image used by CI E2E jobs; main potential impact is unexpected test environment differences or new browser dependencies affecting E2E stability.

Overview
Updates the Playwright container image used by CI E2E workflows from mcr.microsoft.com/playwright:v1.55.0 to v1.59.1.

This applies to the standard e2e workflow, the session replay E2E workflow, and the publish-v2 workflow’s E2E gate to address failures pulling the older container.

Reviewed by Cursor Bugbot for commit 933bd6d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Playwright container version mismatches npm package version
    • Upgraded @playwright/test and corresponding lockfile entries from 1.55.0 to 1.59.1 so the npm Playwright version matches the v1.59.1 CI container image.

Create PR

Or push these changes by commenting:

@cursor push 83f8756139
Preview (83f8756139)
diff --git a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -51,7 +51,7 @@
     "@commitlint/cli": "^17.3.0",
     "@commitlint/config-conventional": "^17.3.0",
     "@nx/workspace": "^21.2.1",
-    "@playwright/test": "1.55.0",
+    "@playwright/test": "1.59.1",
     "@types/jest": "^29.2.4",
     "@types/node": "^18.11.14",
     "@typescript-eslint/eslint-plugin": "^5.46.1",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -28,8 +28,8 @@
         specifier: ^21.2.1
         version: 21.6.8
       '@playwright/test':
-        specifier: 1.55.0
-        version: 1.55.0
+        specifier: 1.59.1
+        version: 1.59.1
       '@types/jest':
         specifier: ^29.2.4
         version: 29.5.14
@@ -2859,8 +2859,8 @@
     resolution: {integrity: sha512-+1VkjdD0QBLPodGrJUeqarH8VAIvQODIbwh9XpP5Syisf7YoQgsJKPNFoqqLQlu+VQ/tVSshMR6loPMn8U+dPg==}
     engines: {node: '>=14'}
 
-  '@playwright/test@1.55.0':
-    resolution: {integrity: sha512-04IXzPwHrW69XusN/SIdDdKZBzMfOT9UNT/YiJit/xpy2VuAoB8NHc8Aplb96zsWDddLnbkPL3TsmrS04ZU2xQ==}
+  '@playwright/test@1.59.1':
+    resolution: {integrity: sha512-PG6q63nQg5c9rIi4/Z5lR5IVF7yU5MqmKaPOe0HSc0O2cX1fPi96sUQu5j7eo4gKCkB2AnNGoWt7y4/Xx3Kcqg==}
     engines: {node: '>=18'}
     hasBin: true
 
@@ -7839,13 +7839,13 @@
     resolution: {integrity: sha512-fjAPuiws93rm7mPUu21RdBnkeZNrbfCFCwfAhPWY+rR3zG0ubpe5cEReHOw5fIbfmsxEV/g2kSxGTATY3Bpnwg==}
     engines: {node: '>=4'}
 
-  playwright-core@1.55.0:
-    resolution: {integrity: sha512-GvZs4vU3U5ro2nZpeiwyb0zuFaqb9sUiAJuyrWpcGouD8y9/HLgGbNRjIph7zU9D3hnPaisMl9zG9CgFi/biIg==}
+  playwright-core@1.59.1:
+    resolution: {integrity: sha512-HBV/RJg81z5BiiZ9yPzIiClYV/QMsDCKUyogwH9p3MCP6IYjUFu/MActgYAvK0oWyV9NlwM3GLBjADyWgydVyg==}
     engines: {node: '>=18'}
     hasBin: true
 
-  playwright@1.55.0:
-    resolution: {integrity: sha512-sdCWStblvV1YU909Xqx0DhOjPZE4/5lJsIS84IfN9dAZfcl/CIZ5O8l3o0j7hPMjDvqoTF8ZUcc+i/GL5erstA==}
+  playwright@1.59.1:
+    resolution: {integrity: sha512-C8oWjPR3F81yljW9o5OxcWzfh6avkVwDD2VYdwIGqTkl+OGFISgypqzfu7dOe4QNLL2aqcWBmI3PMtLIK233lw==}
     engines: {node: '>=18'}
     hasBin: true
 
@@ -12080,9 +12080,9 @@
   '@pkgjs/parseargs@0.11.0':
     optional: true
 
-  '@playwright/test@1.55.0':
+  '@playwright/test@1.59.1':
     dependencies:
-      playwright: 1.55.0
+      playwright: 1.59.1
 
   '@react-native-async-storage/async-storage@1.24.0(react-native@0.70.6(@babel/core@7.28.5)(@babel/preset-env@7.28.5(@babel/core@7.28.5))(encoding@0.1.13)(react@18.2.0))':
     dependencies:
@@ -18813,11 +18813,11 @@
     dependencies:
       find-up: 2.1.0
 
-  playwright-core@1.55.0: {}
+  playwright-core@1.59.1: {}
 
-  playwright@1.55.0:
+  playwright@1.59.1:
     dependencies:
-      playwright-core: 1.55.0
+      playwright-core: 1.59.1
     optionalDependencies:
       fsevents: 2.3.2

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 933bd6d. Configure here.

Comment thread .github/workflows/e2e.yml
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.55.0
image: mcr.microsoft.com/playwright:v1.59.1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright container version mismatches npm package version

High Severity

The container image is upgraded to mcr.microsoft.com/playwright:v1.59.1 but @playwright/test in package.json remains pinned at 1.55.0. Playwright requires the container version and npm package version to match exactly — a mismatch causes browser launch failures due to incompatible executable paths and protocol versions. This will break E2E tests in all three workflows.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 933bd6d. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-graham-amplitude this looks like a valid comment

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflows to use a newer Playwright container image in order to address CI failures pulling the previous Playwright image.

Changes:

  • Bump Playwright Docker image tag from v1.55.0 to v1.59.1 in E2E-related workflows
  • Apply the same container bump to the publish pipeline’s E2E job

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/publish-v2.yml Updates the container image used for the publish workflow’s E2E test job.
.github/workflows/e2e.yml Updates the container image used for the main E2E workflow job.
.github/workflows/e2e-session-replay.yml Updates the container image used for session replay E2E workflow job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

needs: [authorize]
container:
image: mcr.microsoft.com/playwright:v1.55.0
image: mcr.microsoft.com/playwright:v1.59.1
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Playwright Docker image tag is now v1.59.1, but the repo’s Playwright test runner is pinned to @playwright/test 1.55.0 (see package.json:54). Mixing a newer image (with its bundled browsers) with an older Playwright npm version can lead to browser/driver mismatches and flaky or failing runs. Consider bumping @playwright/test (and lockfile) to 1.59.1 to keep versions aligned, or keep the container tag in sync with the npm dependency version.

Suggested change
image: mcr.microsoft.com/playwright:v1.59.1
image: mcr.microsoft.com/playwright:v1.55.0

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/e2e.yml
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.55.0
image: mcr.microsoft.com/playwright:v1.59.1
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now runs in the Playwright v1.59.1 container, but the workspace devDependency @playwright/test is pinned to 1.55.0 (package.json:54). That version skew can cause mismatched bundled browsers vs driver expectations inside the container. Recommend updating @playwright/test to 1.59.1 (and lockfile) or matching the container image tag to the installed Playwright version.

Suggested change
image: mcr.microsoft.com/playwright:v1.59.1
image: mcr.microsoft.com/playwright:v1.55.0

Copilot uses AI. Check for mistakes.
pull-requests: write
container:
image: mcr.microsoft.com/playwright:v1.55.0
image: mcr.microsoft.com/playwright:v1.59.1
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container image was updated to Playwright v1.59.1, but the repo is still pinned to @playwright/test 1.55.0 (package.json:54). In Playwright’s official images, the preinstalled browsers are tied to the image version, so this mismatch can produce inconsistent CI behavior. Consider upgrading @playwright/test to 1.59.1 (and lockfile) or aligning the image tag to 1.55.0.

Suggested change
image: mcr.microsoft.com/playwright:v1.59.1
image: mcr.microsoft.com/playwright:v1.55.0

Copilot uses AI. Check for mistakes.
Mercy811
Mercy811 previously approved these changes Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants