Bugfix/skip commit checks on automated ci upgrades#64856
Bugfix/skip commit checks on automated ci upgrades#64856jscheffl merged 4 commits intoapache:mainfrom
Conversation
jscheffl
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
potiuk and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-2-test
|
I think it's not best solution. What should happen is that we should attempt to commit - and only do "git add & git commit --no-verify" when it fails - because some of the changes done by prek will be committed then - for example generated code or scripts inlined in dockerfile. |
Good idea! Let me update (later...) |
jscheffl
force-pushed
the
bugfix/skip-commit-checks-on-automated-ci-upgrades
branch
from
e4bd7c4 to
1cea06a
Compare
|
Note: Static check is fixed in #64868 |
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 93552c2 v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
* Skip pre-commit checks on automated CI tool upgrades * Skip pre-commit checks on automated CI tool upgrades * Review feedback, attempt with checks once, collect auto-fixes and commit again * Shorten code
* Skip pre-commit checks on automated CI tool upgrades * Skip pre-commit checks on automated CI tool upgrades * Review feedback, attempt with checks once, collect auto-fixes and commit again * Shorten code (cherry picked from commit 93552c2) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
… (#64916) * Skip pre-commit checks on automated CI tool upgrades * Skip pre-commit checks on automated CI tool upgrades * Review feedback, attempt with checks once, collect auto-fixes and commit again * Shorten code (cherry picked from commit 93552c2) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
|
Thanks for "backport-as-a-service" @potiuk ! |
… (#64916) * Skip pre-commit checks on automated CI tool upgrades * Skip pre-commit checks on automated CI tool upgrades * Review feedback, attempt with checks once, collect auto-fixes and commit again * Shorten code (cherry picked from commit 93552c2) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
… (#64916) * Skip pre-commit checks on automated CI tool upgrades * Skip pre-commit checks on automated CI tool upgrades * Review feedback, attempt with checks once, collect auto-fixes and commit again * Shorten code (cherry picked from commit 93552c2) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
… (#64916) * Skip pre-commit checks on automated CI tool upgrades * Skip pre-commit checks on automated CI tool upgrades * Review feedback, attempt with checks once, collect auto-fixes and commit again * Shorten code (cherry picked from commit 93552c2) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
… (#64916) * Skip pre-commit checks on automated CI tool upgrades * Skip pre-commit checks on automated CI tool upgrades * Review feedback, attempt with checks once, collect auto-fixes and commit again * Shorten code (cherry picked from commit 93552c2) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
2 participants
Follow-up from #64836 and comment #64836 (review)
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.