opensearch: generalize extra parameters#65613
Open
DonHaul wants to merge 3 commits intoapache:mainfrom
Open
Conversation
957780c to
1d3ef41
Compare
Contributor
1d3ef41 to
2af56cd
Compare
potiuk
requested changes
Apr 28, 2026
Member
potiuk
left a comment
There was a problem hiding this comment.
I think it is too generic as it might update things we do not want to update via extras. Extras are potentially more sensitive than Hook parameters, because they are configurable by "connection editing" users and not "Dag Authors" - we never pass extras directly to hoo params/args we are always explicit which extras should be passed.
Contributor
Author
|
okay I will specifically define all the parameters in https://opensearch-project.github.io/opensearch-py/_modules/opensearchpy/connection/base.html#Connection . I see that the |
b9b6998 to
1ff244d
Compare
1ff244d to
3ba6c52
Compare
Contributor
Author
|
@potiuk comments addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current OpenSearch hook, does not include the possibility to set arguments for the opensearch client that may be important for some users such as
http_compressandurl_prefixetc.opensearchpylibrary supports many more arguments, includingkwargs- see hereAs such I've generalized the hook so all the parameters in
extraare passed to the opensearch clientWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.