Skip to content

Cherry picking AddFile large batch improvement#38095

Closed
ahmedabu98 wants to merge 6 commits intoapache:masterfrom
ahmedabu98:cp_38039
Closed

Cherry picking AddFile large batch improvement#38095
ahmedabu98 wants to merge 6 commits intoapache:masterfrom
ahmedabu98:cp_38039

Conversation

@ahmedabu98
Copy link
Copy Markdown
Contributor

CP for #38039

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural improvement to the Iceberg AddFiles transform by shifting from direct file commits to a manifest-based approach. By grouping data files into manifests before committing, the pipeline becomes more efficient and scalable. Additionally, the change simplifies configuration by focusing on manifest file size and removes heavy validation logic that was previously causing performance bottlenecks.

Highlights

  • Manifest-based Commit Strategy: Refactored the AddFiles transform to group data files into manifests before committing to Iceberg, improving scalability and performance.
  • Configuration Changes: Replaced 'appendBatchSize' with 'manifestFileSize' to better reflect the new manifest-based batching logic.
  • Removed Resource-Intensive Validation: Removed the in-depth bucket-partition validation logic, as it was too resource-intensive and inconsistent with other implementations like Spark.
  • Dependency Updates: Updated Dataflow container versions to 2.73.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant