boards/tiva: change default toolchain for tm4c123g to GNU EABI#18690
Conversation
1b0b925 to
616e525
Compare
|
Hi @TheFakeMontyOnTheRun, please fix @TheFakeMontyOnTheRun , could you please add some doc about this board? https://nuttx.apache.org/docs/latest/platforms/arm/tiva/index.html As you can see, for TI/Stellaris Tiva there is only lm3s6965-ek board board template |
|
Sorry, I amended the previous commit and forgot to add -S. Will do it when I get home. Regarding the lm3s6965-ek, sorry but I don't understand what you mean? This PR fixes support for https://nuttx.apache.org/docs/latest/platforms/arm/tiva/index.html#ti-tiva-tm4c123g |
I think what @simbit18 said is: you should move the board to a new file, like the lm2s6965-ek and use the https://nuttx.apache.org/docs/latest/contributing/doc_templates/board.html as base: adding a board picture and update the template info about the board. Suggestion: separate all the boards from that page in a different file, but only fix the board that you are working on (later other person will fix the other boards files) |
|
Hi @TheFakeMontyOnTheRun, since you have the tm4c123g-launchpad board and the documentation isn't in ReStructured Text (RST), could you please add it? You can use this template as a guide https://nuttx.apache.org/docs/latest/contributing/doc_templates/board.html and tm4c123g-launchpad -> README.txt Documentation |
|
Maybe the doc change should be a separate PR? |
|
This is strange, CONFIG_ARM_TOOLCHAIN_BUILDROOT_OABI must have been added by mistake. I didn't know this arch supports building that way. |
Yes, makes sense |
616e525 to
7a93850
Compare
|
Dang it, I swear I used -S when commiting this time. I need to further research how to sign it |
fixes: apache#18668 Signed-off-by: Daniel Monteiro <monteiroquiet@gmail.com>
7a93850 to
a31cc4a
Compare
Fixes: #18668
Summary
This will change the default toolchain from OABI to GNU EABI. Out of the box,
Impact
it's a less jarring experience to anyone trying to run NuttX on the TM4C123G. TBH, I'm not even sure how to use OABI (or if it's even possible. My only experience with Buildroot was with Linux).
Sadly, I can't help with other configurations or boards, since I do not own the required hardware to test (I think)?
Should I open an issue for the other boards? Given how wide is the effort to fix this for other boards, it's something to be discussed within the governance of the project .
Testing
Built cleanly on the Machine 3 listed here (#18668).
After programming the board, NuttX worked perfectly on
minicom.Running OSTest did generate an assertion error:
Is this a blocker? In any case, I don't mind opening a separate issue for this.