Skip to content

[Bug] Fix resource leak: properly close RandomAccessFile and FileChannel using try-with-resources #10231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Senrian wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Bug] Fix resource leak: properly close RandomAccessFile and FileChannel using try-with-resources #10231

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59bddc2
Fix resource leak: properly close RandomAccessFile and FileChannel us…
Senrian Mar 30, 2026
e20b3dd
Use read-only mode for RandomAccessFile and FileChannel
Senrian Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/src/main/java/org/apache/rocketmq/tools/command/message/DumpCompactionLogCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ public void execute(CommandLine commandLine, Options options, RPCHook rpcHook)
throw new SubCommandException("file " + fileName + " is a directory.");
}

try {
try (RandomAccessFile raf = new RandomAccessFile(fileName, "rw");
Copy link
Copy Markdown
Member

@lizhimins lizhimins Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use read only mode

FileChannel fileChannel = raf.getChannel()) {
long fileSize = Files.size(filePath);
FileChannel fileChannel = new RandomAccessFile(fileName, "rw").getChannel();
ByteBuffer buf = fileChannel.map(MapMode.READ_WRITE, 0, fileSize);

int current = 0;
Expand Down