[SPARK-53759][PYTHON] Add SimpleWorkerTests for non-daemon worker path#55223
Open
anblanco wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-53759][PYTHON] Add SimpleWorkerTests for non-daemon worker path#55223anblanco wants to merge 1 commit intoapache:masterfrom
anblanco wants to merge 1 commit intoapache:masterfrom
Conversation
anblanco
force-pushed
the
add-simple-worker-tests
branch
from
eaea09f to
1aa617e
Compare
Adds SimpleWorkerTests that runs the full WorkerTests suite through the non-daemon (simple-worker) path by setting spark.python.use.daemon=false. Windows always uses this path. On Linux/macOS it is used when spark.python.use.daemon=false. Includes explicit tests for DataFrame creation, UDF execution, and Python Data Source reads through the simple-worker path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
anblanco
force-pushed
the
add-simple-worker-tests
branch
from
1aa617e to
092420f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SimpleWorkerTeststhat runs the fullWorkerTestssuite through the non-daemon (simple-worker) path by settingspark.python.use.daemon=false. Windows always uses this path; Linux/macOS use it whenspark.python.use.daemon=false.Includes explicit tests for:
These cover the worker paths affected by SPARK-53759, where the simple-worker socket was not explicitly closed before process exit.
Split out from #55201 per reviewer feedback — the fix itself is in #55201, this PR adds the regression test coverage on master.
Test plan
SimpleWorkerTestspasses locally on WSL (Ubuntu 24.04, Python 3.12.3) — 12/12 tests passpyspark.zip), tests fail withEOFException; with the fix, all pass