fix(impersonation): rename DefaultService account to ServiceAccount #27084#27125
Open
alexymantha wants to merge 4 commits intoargoproj:masterfrom
Open
fix(impersonation): rename DefaultService account to ServiceAccount #27084#27125alexymantha wants to merge 4 commits intoargoproj:masterfrom
alexymantha wants to merge 4 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27125 +/- ##
==========================================
+ Coverage 63.33% 63.35% +0.01%
==========================================
Files 415 415
Lines 56545 56545
==========================================
+ Hits 35815 35824 +9
+ Misses 17350 17344 -6
+ Partials 3380 3377 -3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultServiceAccount no longer makes sense and should be named just ServiceAccount instead. This PR only updates the user-facing references, unfortunately we cannot rename the field in the CRDs without a breaking change.
Linked to 327084
Checklist: