Skip to content

fix(impersonation): rename DefaultService account to ServiceAccount #27084#27125

Open
alexymantha wants to merge 4 commits intoargoproj:masterfrom
alexymantha:rename-default-service-account
Open

fix(impersonation): rename DefaultService account to ServiceAccount #27084#27125
alexymantha wants to merge 4 commits intoargoproj:masterfrom
alexymantha:rename-default-service-account

Conversation

@alexymantha
Copy link
Copy Markdown
Member

@alexymantha alexymantha commented Apr 2, 2026

DefaultServiceAccount no longer makes sense and should be named just ServiceAccount instead. This PR only updates the user-facing references, unfortunately we cannot rename the field in the CRDs without a breaking change.

Linked to 327084
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Alexy Mantha <alexy@mantha.dev>
@alexymantha alexymantha requested a review from a team as a code owner April 2, 2026 13:23
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Apr 2, 2026

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-ojrzal.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-ojrzal.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Alexy Mantha <alexy@mantha.dev>
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.35%. Comparing base (62670d6) to head (17539db).

Files with missing lines Patch % Lines
cmd/util/project.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27125      +/-   ##
==========================================
+ Coverage   63.33%   63.35%   +0.01%     
==========================================
  Files         415      415              
  Lines       56545    56545              
==========================================
+ Hits        35815    35824       +9     
+ Misses      17350    17344       -6     
+ Partials     3380     3377       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant