Skip to content

feat(argocd-image-updater): Add parameter to chose namespaced or clusterwide mode#2879

Closed
sribiere-jellysmack wants to merge 4 commits intoargoproj:mainfrom
sribiere-jellysmack:main
Closed

feat(argocd-image-updater): Add parameter to chose namespaced or clusterwide mode#2879
sribiere-jellysmack wants to merge 4 commits intoargoproj:mainfrom
sribiere-jellysmack:main

Conversation

@sribiere-jellysmack
Copy link
Copy Markdown

@sribiere-jellysmack sribiere-jellysmack commented Aug 13, 2024

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

…usterwide mode for AIU

Signed-off-by: Sebastien RIBIERE <sebastien.ribiere.ext@jellysmack.com>
@sribiere-jellysmack
Copy link
Copy Markdown
Author

Related to argoproj-labs/argocd-image-updater#831

Signed-off-by: Sebastien RIBIERE <sebastien.ribiere.ext@jellysmack.com>
@mkilchhofer mkilchhofer added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Aug 13, 2024
@sribiere-jellysmack
Copy link
Copy Markdown
Author

Any review please?

@yu-croco
Copy link
Copy Markdown
Collaborator

yu-croco commented Sep 4, 2024

Hi @sribiere-jellysmack ,
since argo-helm follows upstream and your PR ( argoproj-labs/argocd-image-updater#831 ) is not merged yet in upstream, we put awaiting-upstream label and waiting for it.
When the PR is merged in upstream and argo-image-updater bumps new version for it, we will review.

@mkilchhofer mkilchhofer changed the title feat(argocd-image-updater): add a parameter to chose namespaced or clusterwide mode for AIU feat(argocd-image-updater): Add parameter to chose namespaced or clusterwide mode Sep 11, 2024
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

argocd-image-updater awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. no-pr-activity size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants