Skip to content

EUCLID: update methods cone_search and cross_match_basic so that the parameters table_name and ra_column_name and dec_column_name can be set independently#3496

Merged
bsipocz merged 1 commit intoastropy:mainfrom
esdc-esac-esa-int:ESA_euclid_EUCSD-317_default_columns_in_cone_search
Jan 23, 2026
Merged

EUCLID: update methods cone_search and cross_match_basic so that the parameters table_name and ra_column_name and dec_column_name can be set independently#3496
bsipocz merged 1 commit intoastropy:mainfrom
esdc-esac-esa-int:ESA_euclid_EUCSD-317_default_columns_in_cone_search

Conversation

@cosmoJFH
Copy link
Copy Markdown
Contributor

@cosmoJFH cosmoJFH commented Jan 15, 2026

Dear Astroquery team,

we would like to update the methods cone_search and cross_match_basic so that the parameters table_name and ra_column_name and dec_column_name can be set independently. For example if the parameters ra_column_name and dec_column_name are not explicitely defined, the resulting query contains None values


job = Euclid.cone_search(coordinate=coords, radius=radius, table_name="catalogue.mer_cutouts", async_job=True, verbose = True)

Launched query: '
                SELECT
                  TOP 50
                  *,
                  DISTANCE(
                    POINT('ICRS', None, None),
                    POINT('ICRS', 267.78000034036035, 65.53000542571156)
                  ) AS dist
                FROM
                  catalogue.mer_cutouts
                WHERE
                  1 = CONTAINS(
                    POINT('ICRS', None, None),
                    CIRCLE('ICRS', 267.78000034036035, 65.53000542571156, 0.01)
                  )
                ORDER BY
                  dist ASC
                '

A similar result is obtained for the method cross_match_basic .

cc @esdc-esac-esa-int
jira: EUCLIDPCR-2082

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.83%. Comparing base (9fb78d2) to head (09917e0).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/esa/euclid/core.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3496   +/-   ##
=======================================
  Coverage   71.82%   71.83%           
=======================================
  Files         235      235           
  Lines       20266    20273    +7     
=======================================
+ Hits        14556    14563    +7     
  Misses       5710     5710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor change that seems reasonable

@bsipocz bsipocz added this to the 0.4.12 milestone Jan 15, 2026
@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCSD-317_default_columns_in_cone_search branch 5 times, most recently from bb11899 to 0213fb6 Compare January 21, 2026 08:24
…table_name` and `ra_column_name` and `dec_column_name` independently
@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCSD-317_default_columns_in_cone_search branch from 0213fb6 to 09917e0 Compare January 21, 2026 08:25
Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks all good!

@bsipocz bsipocz merged commit 550a104 into astropy:main Jan 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants