EUCLID: update methods cone_search and cross_match_basic so that the parameters table_name and ra_column_name and dec_column_name can be set independently#3496
Merged
bsipocz merged 1 commit intoastropy:mainfrom Jan 23, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3496 +/- ##
=======================================
Coverage 71.82% 71.83%
=======================================
Files 235 235
Lines 20266 20273 +7
=======================================
+ Hits 14556 14563 +7
Misses 5710 5710 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
approved these changes
Jan 15, 2026
Contributor
keflavich
left a comment
There was a problem hiding this comment.
lgtm, minor change that seems reasonable
bb11899 to
0213fb6
Compare
…table_name` and `ra_column_name` and `dec_column_name` independently
0213fb6 to
09917e0
Compare
bsipocz
approved these changes
Jan 23, 2026
Member
bsipocz
left a comment
There was a problem hiding this comment.
Thank you, this looks all good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Astroquery team,
we would like to update the methods cone_search and cross_match_basic so that the parameters
table_nameandra_column_nameanddec_column_namecan be set independently. For example if the parametersra_column_nameanddec_column_nameare not explicitely defined, the resulting query contains None valuesA similar result is obtained for the method cross_match_basic .
cc @esdc-esac-esa-int
jira: EUCLIDPCR-2082