EUCLID: new parameters in get_observation_products, get_product_list, get_product and get_scientific_product_list to retrieve the products by the dataset release#3514
Conversation
e8a581a to
99611b6
Compare
bsipocz
left a comment
There was a problem hiding this comment.
Thank you for the pull request. Most of it looks good, but there are two topics that needs to be addressed before merging the PR:
-
The argument renames should be done with a deprecation grace using the
deprecated_renamed_argumentdecorator. -
And running the test suite including the remote tests (
tox -e test-online -- -P esa.euclid) I see various failures coming from the documentation, so I expect a couple of the examples in there should be updated, too.
Please fix those, too.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3514 +/- ##
==========================================
+ Coverage 72.21% 72.29% +0.07%
==========================================
Files 217 217
Lines 20276 20336 +60
==========================================
+ Hits 14643 14702 +59
- Misses 5633 5634 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
50cc5f1 to
8709dbf
Compare
bsipocz
left a comment
There was a problem hiding this comment.
The overall diff looks good, but there are a couple of duplicated commits as well as multiple merge commits, so I go ahead and cleanup those a little bit (and also rebase it on the top of the current main as I have some difficulty running the tests locally).
I would expect there is nothing else left from your side, so leave the approval and I go ahead with the merge once the above actions are done with a green CI.
8709dbf to
7de7c4e
Compare
|
There are a couple of doctest failures in Thank you for the PR! |
Dear astroquery team,
we would like to upgrade the signature of the methods
get_observation_products,get_product_list,get_productandget_scientific_product_listso that they now include the new parameters dsr_part1, dsr_part2, dsr_part3 that can be used to retrieve the products by dataset release (that is made of of 3 parts).cc @esdc-esac-esa-int
jira:EUCLIDMNGT-1430