Skip to content

EUCLID: new parameters in get_observation_products, get_product_list, get_product and get_scientific_product_list to retrieve the products by the dataset release#3514

Merged
bsipocz merged 5 commits intoastropy:mainfrom
esdc-esac-esa-int:ESA_euclid_EUCLIDMNGT-1430_versioning_param
Feb 10, 2026
Merged

EUCLID: new parameters in get_observation_products, get_product_list, get_product and get_scientific_product_list to retrieve the products by the dataset release#3514
bsipocz merged 5 commits intoastropy:mainfrom
esdc-esac-esa-int:ESA_euclid_EUCLIDMNGT-1430_versioning_param

Conversation

@cosmoJFH
Copy link
Copy Markdown
Contributor

Dear astroquery team,

we would like to upgrade the signature of the methods get_observation_products, get_product_list, get_product and get_scientific_product_list so that they now include the new parameters dsr_part1, dsr_part2, dsr_part3 that can be used to retrieve the products by dataset release (that is made of of 3 parts).

cc @esdc-esac-esa-int
jira:EUCLIDMNGT-1430

@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCLIDMNGT-1430_versioning_param branch from e8a581a to 99611b6 Compare January 30, 2026 12:31
@bsipocz bsipocz added this to the 0.4.12 milestone Feb 3, 2026
Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. Most of it looks good, but there are two topics that needs to be addressed before merging the PR:

  • The argument renames should be done with a deprecation grace using the deprecated_renamed_argument decorator.

  • And running the test suite including the remote tests ( tox -e test-online -- -P esa.euclid) I see various failures coming from the documentation, so I expect a couple of the examples in there should be updated, too.
    Please fix those, too.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.29%. Comparing base (43cb5dc) to head (7de7c4e).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/esa/euclid/core.py 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3514      +/-   ##
==========================================
+ Coverage   72.21%   72.29%   +0.07%     
==========================================
  Files         217      217              
  Lines       20276    20336      +60     
==========================================
+ Hits        14643    14702      +59     
- Misses       5633     5634       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cosmoJFH cosmoJFH force-pushed the ESA_euclid_EUCLIDMNGT-1430_versioning_param branch from 50cc5f1 to 8709dbf Compare February 4, 2026 10:28
Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall diff looks good, but there are a couple of duplicated commits as well as multiple merge commits, so I go ahead and cleanup those a little bit (and also rebase it on the top of the current main as I have some difficulty running the tests locally).

I would expect there is nothing else left from your side, so leave the approval and I go ahead with the merge once the above actions are done with a green CI.

@bsipocz bsipocz force-pushed the ESA_euclid_EUCLIDMNGT-1430_versioning_param branch from 8709dbf to 7de7c4e Compare February 10, 2026 22:50
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Feb 10, 2026

There are a couple of doctest failures in docs/esa/euclid/euclid.rst, but those are unrelated to this PR, so I go ahead with the merge now.

Thank you for the PR!

@bsipocz bsipocz merged commit 222c771 into astropy:main Feb 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants