Skip to content

Added get_query_payload to astrometry_net#3555

Open
nkphysics wants to merge 4 commits intoastropy:mainfrom
nkphysics:get_query_payload-astrometry_net
Open

Added get_query_payload to astrometry_net#3555
nkphysics wants to merge 4 commits intoastropy:mainfrom
nkphysics:get_query_payload-astrometry_net

Conversation

@nkphysics
Copy link
Copy Markdown
Member

Hey yall, I've added the get_query_payload kwarg to astrometry_net per #2040.

I originally set out to only add get_query_payload functionality, but I noticed too that astrometry_net had deprecated functionality related to solve_from_image. Since deprecation warnings were added back in astroquery 0.4.8 I decided to go through with removing what was deprecated. Going back and looking at closed PRs I think I took care of what yall intended with the deprecation.

All tests both local and remote passed fine for me, but looking back at some of the logs of CI runs it appears that all the remote tests are being skipped 🫤 .
When I ran the remote tests (locally with my api key) they all worked out for me, but just thought I'd throw that note in here just in case to be thorough.

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Mar 16, 2026

please leave the deprecations alone, it's never a good idea to mix new features and cleanups in the same PR.

And, yes, unfortunately the remote tests are really a pain for any of the modules that require authentication.

@bsipocz bsipocz added this to the 0.4.12 milestone Mar 16, 2026
@nkphysics
Copy link
Copy Markdown
Member Author

nkphysics commented Mar 16, 2026

I removed the deprecation removals entirely. If you want me to I have the deprecation removals on a separate branch and can submit a PR for that. Otherwise, this PR should be ready for review.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.84%. Comparing base (b50cfc8) to head (63dd75c).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3555      +/-   ##
==========================================
+ Coverage   72.76%   72.84%   +0.07%     
==========================================
  Files         219      219              
  Lines       20543    20547       +4     
==========================================
+ Hits        14948    14967      +19     
+ Misses       5595     5580      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nkphysics nkphysics force-pushed the get_query_payload-astrometry_net branch from a63dbc5 to dfc43c0 Compare March 16, 2026 21:54
@nkphysics nkphysics changed the title Added get_query_payload to astrometry net and removed deprecated functionality Added get_query_payload to astrometry_net Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants