EUCLID: update de method get_spectrum to retrieve multiple spectra#3570
Draft
cosmoJFH wants to merge 3 commits intoastropy:mainfrom
Draft
EUCLID: update de method get_spectrum to retrieve multiple spectra#3570cosmoJFH wants to merge 3 commits intoastropy:mainfrom
cosmoJFH wants to merge 3 commits intoastropy:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3570 +/- ##
==========================================
+ Coverage 73.09% 73.11% +0.02%
==========================================
Files 219 224 +5
Lines 20592 20873 +281
==========================================
+ Hits 15052 15262 +210
- Misses 5540 5611 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
509b584 to
6af4e46
Compare
Contributor
Author
|
We have found an issue in the documentation, due to the changes introduced in PR #3558: 7 doctests are not displayed since we included a comment after the "doctest-skip::" For example, is not correct. The comment must be included before. We have included the changes in this PR. Would you rather include these changes in a separate PR? |
b3f7c53 to
c700984
Compare
…the unzipped files.
699672e to
e4aeb53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Astroquery team,
Currently the astroquery.euclid.get_spectrum() method allows one to retrieve a single spectrum associated with a given object id (as a string).
This method downloads the spectrum and stores it in a FITS file inside a (created) directory that is written locally. The output of this method is a list with the path to this FITS file, e.g.: ['<local_dir>/temp_20250327_093710/SPECTRA_RGS-sedm 2707008224650763513.fits']
We would like to be able to retrieve multiple spectra data in one single request via Astroquery. In this PR, the input parameter
idsaccepts a <source_id> or a designation (<data-release>+blank+<source_id>) or multiple values separated by commas or a list. In the case multiple values are used and the output_file is not set, the returned files are saved in a zip file named get_spectra_output.zip. The method always returns a dictionary where the key is the name of the returned fits file and the value is a list of Astropy Tables made from the fits file (similar to the Gaia datalink method)cc @esdc-esac-esa-int
jira: EUCLIDMNGT-1457