Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3573 +/- ##
==========================================
+ Coverage 73.10% 73.16% +0.06%
==========================================
Files 224 226 +2
Lines 20839 20918 +79
==========================================
+ Hits 15234 15305 +71
- Misses 5605 5613 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
After some iterations, I managed to pass all the checks. @bsipocz , please let me know if you have any comment |
Contributor
Author
|
Just added the latest changes in the manual. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Astroquery Team,
Many thanks for merging PR #3511. With this, we can now proceed with the new module we already discussed.
We have been preparing a module for the PLATO Archive, to be available for the Guest Observer call for proposals, providing relevant information that may be helpful for astronomers. For this, if possible, we would like to iterate with you and merge this branch as soon as possible, so we have a pre-released version right after this is merged. You can find more information here:
https://www.cosmos.esa.int/web/plato/getting-ready
With this, we have prepared a module based on the EsaTap class we have already discussed, together with specific methods to retrieve data from these catalogues. As you will see, there is also a method to plot data, but we are detecting there if matplotlib is imported and, if not, it raises an exception. This method is also relevant, as it mimics the behavior of an application that is currently used, providing the same features in python script to our users.
With respect to tests, you will see that we have the offline tests and the documentation tests are set to be skipped. This is due to the URL of the TAP, currently not available for the public audience, but it will be opened next week. Right after the Archive is public, we will create another pull request to remove the SKIP clauses and add the remote tests, that we already have.
Many thanks for your support! Please let us know any comment you have.
Kind regards,
@jespinosaar
cc @esdc-esac-esa-int