(Re)added functionality to process datacubes. Includes testing. Rebased.#687
Open
fdeugenio wants to merge 7 commits intoastropy:mainfrom
Open
(Re)added functionality to process datacubes. Includes testing. Rebased.#687fdeugenio wants to merge 7 commits intoastropy:mainfrom
fdeugenio wants to merge 7 commits intoastropy:mainfrom
Conversation
fdeugenio
changed the title
bsipocz
reviewed
Jul 5, 2018
| # THIS TEST HAS BEEN DONE. | ||
| @pytest.mark.parametrize(('aperture_class', 'params'), TEST_APERTURES) | ||
| def test_outside_array(aperture_class, params): | ||
| data = np.ones((100, 10, 10), dtype=np.float) |
Member
There was a problem hiding this comment.
I wonder whether much simplification (and removing this duplication of tests) can be done by parametrizing the input data array, too, one for the 2D and one for the cube case?
Contributor
Author
There was a problem hiding this comment.
Yes indeed, I need some time to do that though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to do aperture photometry on datacubes. This is useful to create single aperture or slit spectra from an integral field spectroscopy datacube.
Rebased on most recent master as per @larrybradley 's comment. Passes all local tests.
Fixed a python2.7 compatibility issue.