#946 Purely operating Ask & Tell removes requirement for target_function#1208
Merged
timruhkopf merged 4 commits intodevelopmentfrom Apr 16, 2025
Merged
Conversation
…then smac does not need to know about the target_function and we can just drop the requirement. Should the user then however decide to call optimize, this must raise an ValueError
benjamc
requested changes
Feb 27, 2025
benjamc
approved these changes
Feb 27, 2025
…then smac does not need to know about the target_function and we can just drop the requirement. Should the user then however decide to call optimize, this must raise an ValueError
benjamc
approved these changes
Feb 27, 2025
…then smac does not need to know about the target_function and we can just drop the requirement. Should the user then however decide to call optimize, this must raise an ValueError
benjamc
approved these changes
Feb 27, 2025
benjamc
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using purely
askandtellinstead ofoptimize, then smac does not need to know about thetarget_functionand we can just drop the requirement by setting it toNone. Should the user then however decide to call optimize, this must raise an ValueError. A few type checks and raises are necessary to ensure proper flow.