Skip to content

Firefox#379

Draft
LucasAlvws wants to merge 14 commits intoautoscrape-labs:mainfrom
LucasAlvws:firefox
Draft

Firefox#379
LucasAlvws wants to merge 14 commits intoautoscrape-labs:mainfrom
LucasAlvws:firefox

Conversation

@LucasAlvws
Copy link
Copy Markdown
Collaborator

@LucasAlvws LucasAlvws commented Mar 6, 2026

Pull Request

Description

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes, no API changes)
  • Performance improvement
  • Tests (adding missing tests or correcting existing tests)
  • Build or CI/CD related changes

How Has This Been Tested?

# Include code examples if relevant

Testing Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Screenshots

Implementation Details

API Changes

Additional Info

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run poetry run task lint and fixed any issues
  • I have run poetry run task test and all tests pass
  • My commits follow the conventional commits style

@LucasAlvws LucasAlvws self-assigned this Mar 6, 2026
@LucasAlvws LucasAlvws added the enhancement New feature or request label Mar 6, 2026
@LucasAlvws LucasAlvws marked this pull request as draft March 6, 2026 16:34
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b0a2dfe9-773c-4e3e-a1e8-6392103c61c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026

…rd modifier support

Move FirefoxElement, FirefoxShadowRoot and FirefoxFindMixin from
browser/firefox/ to elements/, mirroring the Chrome structure where
element classes live in elements/ and browser/ only imports from there.

Uses the same factory function pattern as FindElementsMixin to break
the circular dependency between the find mixin and the element class.

Adds FirefoxElement.key_down, key_up and hotkey with modifier support
(Ctrl+A, Ctrl+C, etc.) using BiDi input.performActions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant