Skip to content

chore: python 3.14 support#394

Open
tiagogcampos wants to merge 2 commits intoautoscrape-labs:mainfrom
tiagogcampos:chore/python314
Open

chore: python 3.14 support#394
tiagogcampos wants to merge 2 commits intoautoscrape-labs:mainfrom
tiagogcampos:chore/python314

Conversation

@tiagogcampos
Copy link
Copy Markdown

@tiagogcampos tiagogcampos commented Apr 6, 2026

Pull Request

Description

Provide support for Python 3.14 by upgrading dependencies, since pydantic-core-2.33.2 does not support it (pyo3).

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes, no API changes)
  • Performance improvement
  • Tests (adding missing tests or correcting existing tests)
  • Build or CI/CD related changes

How Has This Been Tested?

Ran the full test suite for python 3.10-3.14

Testing Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Screenshots

Implementation Details

API Changes

Additional Info

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run poetry run task lint and fixed any issues
  • I have run poetry run task test and all tests pass
  • My commits follow the conventional commits style

Summary by CodeRabbit

  • Chores
    • Expanded continuous integration testing to include Python 3.14, improving compatibility verification across additional language versions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

📝 Walkthrough

Walkthrough

The CI test workflow configuration is updated to include Python 3.14 in the test matrix, extending the list of Python versions from 3.10–3.13 to 3.10–3.14. No changes to workflow logic or steps.

Changes

Cohort / File(s) Summary
CI Test Matrix Configuration
.github/workflows/tests.yml
Added Python 3.14 to the test matrix python-version list to expand version coverage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops through versions new,
Python 3.14 in the queue!
The test matrix grows so fine and bright,
More Python versions to test with delight! 🐍✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and directly summarizes the main change: adding Python 3.14 support to the project's CI test matrix.
Description check ✅ Passed The PR description covers key sections: clear description of changes (Python 3.14 support and dependency upgrades), appropriate type selection (Build or CI/CD), testing confirmation, and completed pre-review checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/tests.yml (1)

16-20: ⚠️ Potential issue | 🟠 Major

Upgrade actions/setup-python to v6 and actions/checkout to v6 for Python 3.14 compatibility.

The workflow currently uses actions/setup-python@v4 and actions/checkout@v3, which are outdated. Since the test matrix includes Python 3.14, upgrading to the latest versions is necessary to ensure proper support and compatibility.

⬆️ Recommended action version upgrades
      - uses: actions/checkout@v3
+     - uses: actions/checkout@v6
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v4
+        uses: actions/setup-python@v6
         with:
           python-version: ${{ matrix.python-version }}

Update to actions/checkout@v6 and actions/setup-python@v6 to ensure Python 3.14.3 compatibility and maintain security best practices.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/tests.yml around lines 16 - 20, The workflow uses outdated
actions versions; update the two action usages shown (actions/checkout@v3 and
actions/setup-python@v4) to actions/checkout@v6 and actions/setup-python@v6
respectively so the test matrix including Python 3.14 is supported—modify the
"uses:" entries for actions/checkout and actions/setup-python in the workflow
snippet (keeping the existing python-version matrix and with: block intact).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/tests.yml:
- Around line 16-20: The workflow uses outdated actions versions; update the two
action usages shown (actions/checkout@v3 and actions/setup-python@v4) to
actions/checkout@v6 and actions/setup-python@v6 respectively so the test matrix
including Python 3.14 is supported—modify the "uses:" entries for
actions/checkout and actions/setup-python in the workflow snippet (keeping the
existing python-version matrix and with: block intact).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3d313dd5-b486-4075-bfaa-6abf9ef7f6b6

📥 Commits

Reviewing files that changed from the base of the PR and between 07f4d9a and a01e6be.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .github/workflows/tests.yml

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant