chore: python 3.14 support#394
Conversation
📝 WalkthroughWalkthroughThe CI test workflow configuration is updated to include Python 3.14 in the test matrix, extending the list of Python versions from 3.10–3.13 to 3.10–3.14. No changes to workflow logic or steps. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/tests.yml (1)
16-20:⚠️ Potential issue | 🟠 MajorUpgrade
actions/setup-pythonto v6 andactions/checkoutto v6 for Python 3.14 compatibility.The workflow currently uses
actions/setup-python@v4andactions/checkout@v3, which are outdated. Since the test matrix includes Python 3.14, upgrading to the latest versions is necessary to ensure proper support and compatibility.⬆️ Recommended action version upgrades
- uses: actions/checkout@v3 + - uses: actions/checkout@v6 - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v4 + uses: actions/setup-python@v6 with: python-version: ${{ matrix.python-version }}Update to
actions/checkout@v6andactions/setup-python@v6to ensure Python 3.14.3 compatibility and maintain security best practices.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tests.yml around lines 16 - 20, The workflow uses outdated actions versions; update the two action usages shown (actions/checkout@v3 and actions/setup-python@v4) to actions/checkout@v6 and actions/setup-python@v6 respectively so the test matrix including Python 3.14 is supported—modify the "uses:" entries for actions/checkout and actions/setup-python in the workflow snippet (keeping the existing python-version matrix and with: block intact).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/tests.yml:
- Around line 16-20: The workflow uses outdated actions versions; update the two
action usages shown (actions/checkout@v3 and actions/setup-python@v4) to
actions/checkout@v6 and actions/setup-python@v6 respectively so the test matrix
including Python 3.14 is supported—modify the "uses:" entries for
actions/checkout and actions/setup-python in the workflow snippet (keeping the
existing python-version matrix and with: block intact).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3d313dd5-b486-4075-bfaa-6abf9ef7f6b6
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
.github/workflows/tests.yml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Pull Request
Description
Provide support for Python 3.14 by upgrading dependencies, since pydantic-core-2.33.2 does not support it (pyo3).
Related Issue(s)
Type of Change
How Has This Been Tested?
Ran the full test suite for python 3.10-3.14
Testing Checklist
Screenshots
Implementation Details
API Changes
Additional Info
Checklist before requesting a review
poetry run task lintand fixed any issuespoetry run task testand all tests passSummary by CodeRabbit