fix: temporary run rosdep install for all packages to detect renamed packages#300
Draft
mitsudome-r wants to merge 3 commits intoautowarefoundation:mainfrom
Draft
fix: temporary run rosdep install for all packages to detect renamed packages#300mitsudome-r wants to merge 3 commits intoautowarefoundation:mainfrom
mitsudome-r wants to merge 3 commits intoautowarefoundation:mainfrom
Conversation
…packages Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
mitsudome-r
changed the title
Member
Author
|
Testing in my fork. OLD build-and-test: NEW build-and-test: |
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
|
This pull request has been automatically marked as stale because it has not had recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had a situation where build-and-test-differential passed against a PR but main build CI failed after PR being merged.
autowarefoundation/autoware_universe#7351
https://github.com/autowarefoundation/autoware.universe/actions/runs/9451850160/job/26033742910
This is due to the change in package name, and current workflow won't be able to check packages that depends on removed package.
This PR will run rosdep against all packages in the workspace instead of only against modified packages to detect packages that still depends on removed package in the workspace.
Tests performed
I need some testing the updated action.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.