Skip to content

chore(deps): add esbuild as explicit devDependency#5173

Merged
svozza merged 3 commits intomainfrom
chore/esbuild-dev-dependency
Apr 7, 2026
Merged

chore(deps): add esbuild as explicit devDependency#5173
svozza merged 3 commits intomainfrom
chore/esbuild-dev-dependency

Conversation

@sdangol
Copy link
Copy Markdown
Contributor

@sdangol sdangol commented Apr 7, 2026

Summary

Changes

Add esbuild as an explicit devDependency in the root package.json. After the Vitest upgrade moved to Vite 8, esbuild was dropped as a transitive dependency since Vite 8 switched from esbuild to Rolldown. This caused CDK's NodejsFunction to fall back to Docker-based bundling during e2e tests, resulting in exec format error failures on CI runners.

Issue number: closes #5172


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@powertools-for-aws-oss-automation powertools-for-aws-oss-automation bot added size/XS PR between 0-9 LOC and removed size/XS PR between 0-9 LOC labels Apr 7, 2026
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation bot added size/XS PR between 0-9 LOC and removed size/XS PR between 0-9 LOC labels Apr 7, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@svozza svozza merged commit 0fd814e into main Apr 7, 2026
99 checks passed
@svozza svozza deleted the chore/esbuild-dev-dependency branch April 7, 2026 17:01
@dreamorosi
Copy link
Copy Markdown
Contributor

I disagree that this should be a root-level package.

AWS CDK is not a root level package either and is instead used (and depended upon) in packages/testing and layers - esbuild should've been added as a non-dev dependency to both of these imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS PR between 0-9 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Add esbuild as explicit devDependency after Vite 8 dropped it as transitive dependency

3 participants