You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @adv4000, thanks for the contribution! The S3 Gateway Endpoint idea is genuinely valuable — it's free, improves security, and keeps S3 traffic on the AWS private network.
However, we'd like to revisit the design before merging:
S3 Endpoint should be tied to S3 plugin opt-in, not CreateVPCEndpoints
Our design principle for this template is: infrastructure is only created when the user has opted into the feature that needs it. The S3 Gateway Endpoint is only meaningful if the user has chosen to install the S3 plugin. Bundling it with CreateVPCEndpoints creates infrastructure for a feature the user may never use.
The right approach would be a dedicated parameter (e.g. EnableS3Plugin: true/false) that, when enabled, does both things
together: 1. Creates the S3 Gateway Endpoint
2. Installs the S3 plugin during setup
Please revert the KeyPairName type change
Changing Type: String to Type: AWS::EC2::KeyPair::KeyName causes deployment failures — CloudFormation validates that the value is an existing key pair, so the default "none" is rejected. Please revert this change across all files.
We'd love to get a revised version of this merged — the S3 Endpoint + plugin pairing is a solid feature. Happy to answer any questions on the design. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added S3 Gateway Endpoint for Private access to/from S3, also cost saving.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.