Set default CPU template to T2 for cross-platform VM compatibility#34
Open
liujunhui2 wants to merge 3 commits intoaws-samples:mainfrom
Open
Set default CPU template to T2 for cross-platform VM compatibility#34liujunhui2 wants to merge 3 commits intoaws-samples:mainfrom
liujunhui2 wants to merge 3 commits intoaws-samples:mainfrom
Conversation
Without a CPU template, Firecracker VMs inherit host CPU features, which can cause failures when migrating VMs across different CPU platforms. Default to T2 with optional override via ProcessOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Allow overriding the default T2 CPU template via the FC_CPU_TEMPLATE environment variable for AMD (T2A) and ARM (V1N1) hosts. Add VM configuration section to README with template descriptions and usage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Return a clear error if an invalid CPU template is specified via the environment variable, instead of failing at the Firecracker API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setMachineConfig, ensuring VMs don't inherit host-specific CPU features that break cross-platform migrationCPUTemplatefield toProcessOptionsto allow callers to override the default (e.g. T2A for AMD, T2CL for Cascade Lake)Test plan
go build ./...passes in the orchestrator package🤖 Generated with Claude Code