Merged
Conversation
sirknightj
reviewed
Apr 23, 2025
...main/java/com/amazonaws/kinesisvideo/demoapp/fragment/StreamWebRtcConfigurationFragment.java
Outdated
Show resolved
Hide resolved
...main/java/com/amazonaws/kinesisvideo/demoapp/fragment/StreamWebRtcConfigurationFragment.java
Outdated
Show resolved
Hide resolved
sirknightj
approved these changes
Apr 24, 2025
app/src/main/java/com/amazonaws/kinesisvideo/demoapp/util/KvsClientFactory.java
Outdated
Show resolved
Hide resolved
unicornss
reviewed
Apr 25, 2025
app/src/main/java/com/amazonaws/kinesisvideo/demoapp/util/KvsClientFactory.java
Outdated
Show resolved
Hide resolved
unicornss
reviewed
Apr 25, 2025
app/src/main/java/com/amazonaws/kinesisvideo/demoapp/util/KvsClientFactory.java
Show resolved
Hide resolved
unicornss
approved these changes
Apr 29, 2025
…lientFactory.java Co-authored-by: sirknightj <jggunawa@amazon.com>
67d3176 to
d4e70f9
Compare
stefankiesz
added a commit
that referenced
this pull request
Dec 22, 2025
* Dual-Stack Endpoint Support (#112) * Add the dual-stack checkbox * Change checkbox to switch, improve margins * Move KVS client creation to separate class * Update app/src/main/java/com/amazonaws/kinesisvideo/demoapp/util/KvsClientFactory.java Co-authored-by: sirknightj <jggunawa@amazon.com> * Address comments * Add dual-stack STUN url * Update UI component * Fix rebase * Actually fix rebase * Add back custom endpoint capabilities * Add missing import --------- Co-authored-by: sirknightj <jggunawa@amazon.com> * Update versionName to 1.3.0 (#124) --------- Co-authored-by: sirknightj <jggunawa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.