Skip to content

make TypeIdMap iteration order respect its comment#23864

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
mockersf:TypeIdMap-iteration-order
Apr 18, 2026
Merged

make TypeIdMap iteration order respect its comment#23864
alice-i-cecile merged 3 commits intobevyengine:mainfrom
mockersf:TypeIdMap-iteration-order

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Apr 17, 2026

Objective

Solution

  • Replace the backing HashMap by an IndexMap

Testing

  • CI

@mockersf
Copy link
Copy Markdown
Member Author

mockersf commented Apr 17, 2026

I don't know if the iteration order is sensitive in all places, but it seems easier to make the type actually respect its comment

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Reflection Runtime information about types X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 17, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Reflection Apr 17, 2026
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 18, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 18, 2026
Merged via the queue into bevyengine:main with commit 7a42034 Apr 18, 2026
54 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Reflection Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

Reflection
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeIdMap comment is wrong about iteration order

3 participants

@mockersf @kfc35 @alice-i-cecile