[PM-34422] [IS] feat: Add card number format grouping#2506
Open
fedemkr wants to merge 5 commits intoPM-33989/card-scannerfrom
Open
[PM-34422] [IS] feat: Add card number format grouping#2506fedemkr wants to merge 5 commits intoPM-33989/card-scannerfrom
fedemkr wants to merge 5 commits intoPM-33989/card-scannerfrom
Conversation
fedemkr
added
the
innovation
github-actions
bot
added
the
app:password-manager
fedemkr
changed the title
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PM-33989/card-scanner #2506 +/- ##
=========================================================
+ Coverage 85.80% 86.92% +1.11%
=========================================================
Files 2090 1860 -230
Lines 179123 164468 -14655
=========================================================
- Hits 153702 142966 -10736
+ Misses 25421 21502 -3919 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ng-UI # Conflicts: # BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditCardItem/AddEditCardItemState.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-34422
📔 Objective
Add card number format grouping to the cipher add/edit card number fields.
Note
This follows the same logic as in
clientsrepo: https://github.com/bitwarden/clients/blob/7dbc30ee059606e0fb2a21d135f1f4cbd92e1b8a/libs/angular/src/pipes/credit-card-number.pipe.ts#L11📸 Screenshots