Return 400 instead of 500 when Origin is missing from FIDO2 requests#840
Merged
Return 400 instead of 500 when Origin is missing from FIDO2 requests#840
Conversation
Validate Origin in GetFido2Instance so a null value throws an ApiException(400) instead of letting the Fido2 library blow up with an unhandled ArgumentNullException. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage 36.80% 36.81%
=======================================
Files 586 586
Lines 31474 31476 +2
Branches 903 904 +1
=======================================
+ Hits 11585 11587 +2
Misses 19742 19742
Partials 147 147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jrmccannon
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate Origin in GetFido2Instance so a null value throws an ApiException(400) instead of letting the Fido2 library blow up with an unhandled ArgumentNullException.
Shape
Adds e2e tests and validation.
Screenshots
Checklist
I did the following to ensure that my changes were tested thoroughly:
I did the following to ensure that my changes do not introduce security vulnerabilities: